This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Report when flake8 crashes! #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flake8 crashes for some reason this was being transparently hidden from the user. Instead show the most recent call to the user, with the full Python stack trace being printed to the console.
Arcanemagus
force-pushed
the
arcanemagus/report-errors
branch
from
c3f7b67
to
dce14bf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flake8 crashes for some reason this was being transparently hidden from the user. Instead show the most recent call to the user, with the full Python stack trace being printed to the console.
Example:
(Thanks to the current bug breaking
flake8-docstringsfor this simple reproduction case!)The current behavior of hiding the error was introduced in #167 and unfortunately I didn't think of what the full rammifications were there and blindly trusted the report of:
Which in hindsight sounds ridiculous and was likely a result of a system configuration issue from that user (who has since deleted their account).