This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Support v2 Linter API #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason for using Go 1.8 with the stable channel and Go 1.9 with the beta channel? |
|
Tests are failing because of this golang/go#28291, |
The current versions that are fully supported by go are: v1.10 and v1.11, golang/tools#52
It's likely that when CI was configured Go 1.9 wasn't out yet. |
Arcanemagus
suggested changes
Jan 30, 2019
lib/main.js
Outdated
| if (std !== null || std !== '') { | ||
| let match = regex.exec(std); | ||
| while (match !== null) { | ||
| // Bump line number down 2 instead of 1 due to inserted extra line |
There was a problem hiding this comment.
🔥 Looks like this comment snuck in from a different provider (where it was accurate).
stream must not be null and must not be empty
Arcanemagus
approved these changes
Jan 30, 2019
|
Appveyor is fast as an old mule... 😴 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121