This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
A few fixes #21
Merged
A few fixes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jschroeder9000 here is a base to start things off of, feel free to commit to this branch since it's off of this repo. This partially fixes #12, but until steelbrain/atom-linter#85 is dealt with I don't think parse should be used since it would only have a single character highlighted. The major improvement still needing to be done from here is the temp file handling like you discussed over in #13. |
This will for EOL to be LF.
Instead of figuring this out here, just use the helper function created for this purpose.
Instead of utilizing BufferedProcess directly use helpers.exec() to handle running the process.
Also move all properties together.
Also updates the engines field to the current recommended value.
|
I'm merging this in so future dependency updates start from a valid base and don't require a bit of work. |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
This should fix #14 since helpers.rangeFromLineNumber works around the Atom bug that is triggering that message.
Fixes #15.