Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Provide a default PATH for finding shellcheck #7

Closed
alex opened this issue Aug 29, 2014 · 3 comments
Closed

Provide a default PATH for finding shellcheck #7

alex opened this issue Aug 29, 2014 · 3 comments
Labels

Comments

@alex
Copy link

alex commented Aug 29, 2014

Right now the default is empty, which results in ENOENT the first time you load up a shell script, it would be better if a default of some sort was provided.

@exalted
Copy link

exalted commented May 7, 2015

Actually copied which spellcheck |pbcopy and pasted into settings, but then it saved

"linter-shellcheck”:
    shellcheckExecutablePath: '''

/usr/local/bin/shellcheck
'''

Rather than

"linter-shellcheck":
    shellcheckExecutablePath: "/usr/local/bin/shellcheck”

Which gives me the same error @alex commented issued.

Anyhow, I needed to fix it manually ~/.atom/config.cson.

@project0
Copy link
Contributor

project0 commented Aug 8, 2015

should be fixed by #21 . Default is just 'shellcheck' which needs to be available by $PATH.

lexicalunit added a commit to lexicalunit/linter-shellcheck that referenced this issue Dec 4, 2015
On OS X electron frequently does not seem to pick up the PATH setting
correctly when launching Atom from a GUI, for example the Dock. This
means that shellcheck can not be found. One workaround is to specify the
absolute path to shellcheck, but this can be done automatically. This
provides a much better experience for users on OS X.

This should also resolve issue AtomLinter#7 for many users.

- Adds `enableFixPath` option.
- Adds documentation for option to README.
- Adds observer for option, once turned on it can't be reversed.
- Defaults `enableFixPath` to true for 'darwin` (OS X) platform.
- Provides user documentation for option, indicating its use in OS X.
lexicalunit added a commit to lexicalunit/linter-shellcheck that referenced this issue Dec 4, 2015
On OS X electron frequently does not seem to pick up the PATH setting
correctly when launching Atom from a GUI, for example the Dock. This
means that shellcheck can not be found. One workaround is to specify the
absolute path to shellcheck, but this can be done automatically. This
provides a much better experience for users on OS X.

This should also resolve issue AtomLinter#7 for many users.

- Adds `enableFixPath` option.
- Adds documentation for option to README.
- Adds observer for option, once turned on it can't be reversed.
- Defaults `enableFixPath` to true for 'darwin` (OS X) platform.
- Provides user documentation for option, indicating its use in OS X.
- Adds optional `fix-path` dependency (avoid issues with non-OS X OS's).
lexicalunit added a commit to lexicalunit/linter-shellcheck that referenced this issue Dec 4, 2015
On OS X electron frequently does not seem to pick up the PATH setting
correctly when launching Atom from a GUI, for example the Dock. This
means that shellcheck can not be found. One workaround is to specify the
absolute path to shellcheck, but this can be done automatically. This
provides a much better experience for users on OS X.

This should also resolve issue AtomLinter#7 for many users.

- Adds `enableFixPath` option.
- Adds documentation for option to README.
- Adds observer for option, once turned on it can't be reversed.
- Defaults `enableFixPath` to true for 'darwin` (OS X) platform.
- Provides user documentation for option, indicating its use in OS X.
- Adds `fix-path` dependency.
@Arcanemagus
Copy link
Member

Marking this as closed, the default is now shellcheck, which will work if your Atom environment is good. If you are on OS X with a broken environment though you will need to specify the full path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants