This repository has been archived by the owner on Jul 21, 2022. It is now read-only.
Ct 1311 cherrypick unicode fixes #288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flebel
approved these changes
Mar 20, 2020
| @@ -157,6 +157,13 @@ def process_upload_filepath(path, strict=True): | |||
| paths = [] | |||
|
|
|||
| if path: | |||
| try: | |||
There was a problem hiding this comment.
Can you update the docstring to add this verification step?
|
I'll wait until the customer that encountered the issue that prompted this fix has had a chance to use it in a pre-release before merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I had already merged yesterdays related PR)
Based on Slack conversations re unicode strategy, I added a shield in process_upload_filepath() to catch unicode filenames early.
The dialog points straight to the problematic file.
There are some other unicode error/logging handling fixes, which should never be reached now anyway.