This repository has been archived by the owner on May 10, 2024. It is now read-only.
Update rapidjson to fix #710 #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update rapidjson to v1.1.0. This library version always uses '.' as decimal separator instead of the separator selected by the current locale. This should fix #710.
Use pre-increment operators for iterators in order to avoid a temporary copy. Also use the canonical itr->MemberFun() instead of (*itr).MemberFun().
|
Can one of the admins verify this patch? |
|
Thanks for the PR, I perused it briefly and looking good. I'll review more closely and do some testing soon 👍 |
|
@AtomicBuildBot retest this please |
|
Awesome, thanks for the rapidjson update and associated cleanups! LANDING! Closes #710 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rapidjson to v1.1.0. This library version always uses '.' as decimal
separator instead of the separator selected by the current locale. This
should fix #710.