easy_profiler integration #1531

rokups · 2017-04-28T10:57:07Z

This PR integrates easy_profiler replacing old and not really useful on-screen profiler.

Features:

Profiling data is cached and sent over network (easy mobile device and application startup profiling)
Profiling data can be saved to file and loaded later
Profiler recognizes different threads
Options for changing profiled block color (displayed in profiler tool). Events are orange, resource loading is blue
Profiler tool is using Qt5. On systems where Qt is not available cmake will display warning but engine will still build
C# support, requires projects to define ATOMIC_PROFILING.
Profiler is enabled automatically for debug builds
Command line parameters to set profiler port and enable/disable application listening for profiler connections

In the future easy_profiler maintainers plan support for dx11/12, opengl, vulkan and cuda profiling. Maintainers were very helpful and implemented non-scoped profiler blocks on my request. Tracking arbitrary values (my request as well) is already in the works, this will be useful for tracking c#/js object counts and what not.

I found a way to do reasonably low-overhead c# code block profiling using lambda. There is still a chance to optimize a little by defining custom bindings to Profiler::BeginBlock() which takes const char* as parameter. It looks like this:

Profiler.Block("BlockName", () => {
    // Code here
});

I did not add js support, however it is trivial. Is there a spot somewhere we could add some extra code for typescript to use much like Script/AtomicNET/AtomicNET/Core/Profiler.cs? In js it would look like so:

Profiler.block("BlockName", function() {
    // Code here
});

Can we set engineParameters_ from c#/js applications? If we can - how? We need this in order to make listening for profiler connections opt-in instead of opt-out.

TODO:

js support
Add ATOMIC_PROFILING to debug configurations of C# projects
Make profiler not listen by default
Add manual optimized bindings for Profiler::BeginBlock()

Please review.

JoshEngebretson · 2017-05-16T16:38:08Z

Great, thanks 👍, I'll give this a whirl later today once I can get back to macOS

JoshEngebretson · 2017-05-16T19:09:11Z

Great work! It is a lot more stable on macOS and the UI seems to be working other than the thread ID's which are still not quite being calculated properly. I did try and disconnect and then reconnect and the Qt profiler app hangs on macOS when doing this... can you disconnect/reconnect for you?

EDIT: Force quitting the Profiler application and restarting it and I could reconnect to the player app and start capturing again, so is Profiler app specific

EDIT 2: I get this crash quite a bit, seem to be able to trigger it with right click select of the timespan, though also believe I got it once when Profiler app was in background process:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   Profiler                      	0x0000000103ba02dc EasyGraphicsView::onIdleTimeout() + 14828 (blocks_graphics_view.cpp:1635)
1   Profiler                      	0x0000000103bb20da QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (EasyGraphicsView::*)()>::call(void (EasyGraphicsView::*)(), EasyGraphicsView*, void**) + 122 (qobjectdefs_impl.h:143)
2   Profiler                      	0x0000000103bb2030 void QtPrivate::FunctionPointer<void (EasyGraphicsView::*)()>::call<QtPrivate::List<>, void>(void (EasyGraphicsView::*)(), EasyGraphicsView*, void**) + 80 (qobjectdefs_impl.h:163)
3   Profiler                      	0x0000000103bb1f56 QtPrivate::QSlotObject<void (EasyGraphicsView::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) + 166 (qobject_impl.h:121)
4   org.qt-project.QtCore         	0x0000000104ada22b QMetaObject::activate(QObject*, int, int, void**) + 731
5   org.qt-project.QtCore         	0x0000000104ad3320 QObject::event(QEvent*) + 48
6   org.qt-project.QtWidgets      	0x0000000103e1a58d QApplicationPrivate::notify_helper(QObject*, QEvent*) + 269
7   org.qt-project.QtWidgets      	0x0000000103e1ced2 QApplication::notify(QObject*, QEvent*) + 5906
8   org.qt-project.QtCore         	0x0000000104aa9544 QCoreApplication::notifyInternal2(QObject*, QEvent*) + 164
9   org.qt-project.QtCore         	0x0000000104afe9d6 QTimerInfoList::activateTimers() + 1142
10  libqcocoa.dylib               	0x00000001078deae2 QCocoaEventDispatcherPrivate::activateTimersSourceCallback(void*) + 18

JoshEngebretson · 2017-05-16T19:36:29Z

I was able to profile on Android (awesome! 🚀 ) and the thread id's appear to be the same number:

rokups · 2017-06-06T13:36:24Z

@JoshEngebretson easy_profiler maintainers did some work on networking and threading. Our changes were upstreamed as well. I rebased this branch on to master, cleaned it up, updated easy_profiler, fixed crash with event profiling (its a bit dirty, but works great). I squashed all commits as they were more wandering in the woods than meaningful work.. Squashing ate your changes, but rest assured your mark in history of humanity was presedved :)

Please test profiler tool on MacOS. I commented out that socket.listen() loop for now and i hope it will work without said loop and i can clean it up from commit history altogether.

JoshEngebretson · 2017-06-06T14:54:36Z

@rokups Awesome sauce! Thanks, and will test and review as soon as possible 👍

cas4ey · 2017-06-11T17:13:23Z

@JoshEngebretson Hello! I'm collaborator of easy_profiler. I saw you had a crash in GUI. Does the problem still exist? If yes, could you, please, send me .prof file with which you had the problem?

JoshEngebretson · 2017-06-11T17:51:38Z

Hello @cas4ey , thanks for your excellent work on easy_profiler! I have not reproduced any crashes in recent testing of the profiler branch, will let you know if I do 👍

rokups · 2017-06-12T08:50:32Z

@JoshEngebretson i updated to latest profiler code and rebased on to engine master. Connection log spam is no longer there and it seems network quirks are fixed. Please test how it fares on MacOS.

Also please point me to some example of manual binding example for c# and to some example how to add extra code for js. I would like to try adding something like AtomicNET/Core/Profiler.cs
to javascript.

JoshEngebretson · 2017-06-12T13:25:07Z

Awesome, I'll be able to test this later today. I'll also provide some guidance for C#/JS 🐫

Edit: Looks like there are some include path issues with the profiler on Windows/macOS according to the logs, note CI builds in release

rokups · 2017-06-13T16:15:19Z

Something weird is going on here and i cant figure it out. Could you please take a look? Search build log for -- Library type: SHARED (easy profiler library type). Due to this it should be STATIC. This variable is created here, but according to cmake docs it only creates CACHE variable if it is missing. Otherwise value is left intact. I confirmed it testing on my machine. Something odd is going on here. I also had to add this workaround for mac build because it didnt work with CXX_STANDARD 11 even though cmake version is high enough to support it. If you got any ideas whats going on here i am all ears.

JoshEngebretson · 2017-06-13T16:34:56Z

I am not sure on the CMake workaround, 3.1.2 is what is on build box. If we're modifying the stock easy_profiler CMake, please mark with // ATOMIC BEGIN and // ATOMIC END block with a note about modification, this helps when updating and also removing changes when they are no longer necessary.

I'll have a look at the build when I get a chance here, won't be too long ;) Great work!

JoshEngebretson · 2017-06-13T22:42:04Z

@AtomicBuildBot retest this please

rokups · 2017-06-14T09:19:48Z

@AtomicBuildBot retest this please

JoshEngebretson · 2017-06-15T01:09:56Z

Source/ThirdParty/easy_profiler/CMakeLists.txt

+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_LIST_DIR}/bin)
+set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_LIST_DIR}/bin)
+set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_LIST_DIR}/bin)
+


These output overrides cause an error when building for multiple platforms as each platform's binaries will be in the same location, in the source instead of build tree:

%ATOMIC_ROOT%/Source/ThirdParty/easy_profiler/easy_profiler_core/Release

instead of for example:

%ATOMIC_ROOT%/Artifacts/Build/Mac/Source/ThirdParty/easy_profiler/easy_profiler_core/Release
%ATOMIC_ROOT%/Artifacts/Build/IOS/Source/ThirdParty/easy_profiler/easy_profiler_core/Release
%ATOMIC_ROOT%/Artifacts/Build/Android/Source/ThirdParty/easy_profiler/easy_profiler_core/Release

Disabling these output directory overrides, and ./Build_AtomicEditor.sh --with-android --with-ios works. I think this is a fine solution, though should put // ATOMIC BLOCKS and a description of why disabled. This isn't standard CMake for a third party library and should probably be addressed upstream.

rokups · 2017-06-15T08:46:15Z

Finally it builds \o/ @JoshEngebretson thank you very much for spotting that easy_profiler cmake quirk. Fresh set of eyeballs are a great thing o/ I will try to upstream that change as well.

rokups · 2017-06-15T09:56:33Z

I am afraid at least on windows profiler deployment is complicated.

profiler_gui can not build if engine links to static runtime because prebuilt Qt libraries link to dynamic msvc runtime. profiler_gui links to easy_profiler lib here, and lib inherits static runtime from the engine.

We can build profiler_gui with -DATOMIC_DYNAMIC_RUNTIME=1, however then editor and few other targets fail to build because CEF links to static runtime.

We have to do one of the following on windows:

Build Qt linking to static msvc runtime.
Build CEF linking to dynamic msvc runtime.
Generate -DATOMIC_DYNAMIC_RUNTIME=0 and build engine without providing it access to Qt. Generate build with -DATOMIC_DYNAMIC_RUNTIME=1 and build profiler_gui only. Copy profiler tool with Qt dlls to static build directory for distribution.

JoshEngebretson · 2017-06-19T14:32:54Z

Source/ThirdParty/easy_profiler/CMakeLists.txt

-add_subdirectory(profiler_gui)
+# ATOMIC BEGIN
+if (MSVC AND "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
+    message(STATUS "Profiler GUI can only be built in Release builds with MSVC compiler.")


Does this cause the easy profiler cmake to look for debug Qt libs? If so, maybe can be configured to use Release Qt libs regardless in easy profiler scripts? If not, or another reason, lemme know. I think this is acceptable, though would be good to have Profiler client available in debug builds, which could also be sorted later.

I do not think it is possible to kick certain targets into "Release" build when everything else is building as "Debug". But maybe we could just remove -DDEBUG=1 (which is implicit) and use /MD and have release build within debug build. That that might work, i will try.

JoshEngebretson · 2017-06-19T14:33:09Z

Source/ThirdParty/easy_profiler/easy_profiler_core/CMakeLists.txt

@@ -143,6 +143,8 @@ else ()
    endif ()
 endif ()

+# ATOMIC BEGIN
+if (0)


Good catch on the install stuff

JoshEngebretson · 2017-06-19T14:34:04Z

Source/ThirdParty/easy_profiler/easy_profiler_core/CMakeLists.txt

+if (MSVC)
+    add_library(easy_profiler_md ${EASY_OPTION_LIB_TYPE} ${SOURCES} resources.rc)
+    foreach(prop COMPILE_DEFINITIONS COMPILE_OPTIONS CXX_STANDARD CXX_STANDARD_REQUIRED INCLUDE_DIRECTORIES INTERFACE_COMPILE_DEFINITIONS INTERFACE_COMPILE_OPTIONS INTERFACE_INCLUDE_DIRECTORIES INTERFACE_LINK_LIBRARIES)
+        get_target_property(val easy_profiler ${prop})


Fancy footwork, the cmake is strong with this one! 🐫

JoshEngebretson · 2017-06-19T14:34:43Z

Source/ThirdParty/easy_profiler/profiler_gui/CMakeLists.txt

+    # ATOMIC BEGIN
+    target_link_libraries(profiler_gui Qt5::Widgets)
+    if (TARGET easy_profiler_md)
+        target_compile_options(profiler_gui PRIVATE /MD)


Very nice and clean 👍

rokups · 2017-06-22T09:14:17Z

Again sorry for taking forever. Real life and summer caught up to me.

Sometimes i can be idiot of epic proportions. I completely forgot the fact that Qt ships both release and debug builds of their libraries. Forcing a release (/MD) build in otherwise debug build of engine was causing issues and completely unnecessary. Once i realized this it was easy to have it build debug version of profiler that links to dynamic msvc runtime just like rest of Qt. It all works perfectly. I also rebased branch on latest master.

To deploy profiler dlls on windows we are supposed to run this: C:\Qt\5.9\msvc2017_64\bin\windeployqt.exe --no-angle --no-opengl-sw --no-translations C:\Atomic-easy_profiler\AtomicGameEngine\Artifacts\Build\Profiler\Release\Profiler.exe. It dumps minimal required Qt libraries into directory where Profiler.exe is located.

@JoshEngebretson please give it a spin on MacOS and let me know if something is still missing or if is it complete now.

#1566 makes Add manual optimized bindings for Profiler::BeginBlock() goal obsolete so i am crossing it out.

Also please point me to some example how to add extra code for js. I would like to try adding something like AtomicNET/Core/Profiler.cs
to javascript.

If profiling on MacOS works as expected and when i add this js bit i think this PR will be complete.

JoshEngebretson · 2017-06-22T20:11:21Z

@rokups Absolutely zero worries man, this is a mega-feature! 😎

I am really swamped here today, will test at first opportunity. That's good news on the Windows side of things, thanks for R&D'ing it

Also, I haven't forgotten #1566. I'll look into whipping up a quick hand binding example for the profiler if that gets hairy (or for the meantime).

HeadClot · 2017-06-23T03:43:25Z

This is insane. Just saw the Repo for easy profiler. Super happy to see this in AGE :)

Type1J · 2017-06-23T13:16:28Z

@rokups This is great! Good job!

rokups · 2017-06-23T17:48:48Z

Thanks for applauds guys :) 👏

@JoshEngebretson optimized c# bindings are working. One more piece of the puzzle is that generated c# projects do not have ATOMIC_PROFILING defined. It should be defined at least in debug builds and it is ok if it is defined even if engine is built without ATOMIC_PROFILING. I can not find where i should change that. Halp 🆘

JoshEngebretson · 2017-06-23T17:52:09Z

Script/AtomicNET/AtomicNET/Core/Profiler.cs

@@ -12,12 +13,16 @@ public partial class Profiler : AObject
        {
 #if ATOMIC_PROFILING
            var profiler = AtomicNET.GetSubsystem<Profiler>();
-            profiler?.BeginBlock(name, file, line, color, (byte)status);
+            if (profiler != null)


We don't need AtomicNET here, AObject has GetSubsystem on it, the static AtomicNET flavor is only for getting a subsystem outside of a AObject derived instance. Also, it might be good to locally cache so doesn't look up per block.

We don't need AtomicNET here, AObject has GetSubsystem on it

👍

locally cache

You mean Profiler.Block() should not be static so that caller gets Profiler and reuses that reference?

I mean so don't need to call GetSubsystem per block, which is not a terribly expensive call, though still, if that gets ugly that's fine, can cross bridge if it is an issue 🐫

BTW, will this be the first C# code profiled with easy_profiler @cas4ey?, awesome work again @rokups 🥇

This caching of subsystem pointers seem to comes up rather often. Maybe it would be better idea for next PR to cache engine subsystems as weak pointers in Context?

JoshEngebretson · 2017-06-23T17:52:42Z

Source/AtomicNET/NETNative/NETCInterop.cpp

@@ -750,7 +751,15 @@ namespace Atomic
        }
 #endif

+#if ATOMIC_PROFILING
+        ATOMIC_EXPORT_API void csi_Atomic_Profiler_BeginBlock(Profiler* profiler, const char* name, const char* file, int line, unsigned int argb, unsigned char status)
+        {


Let's make sure the csi_Atomic_Profiler_BeginBlock is available in the shared library, whether profiling is enabled or not... will avoid missing symbols. Can ifdef the profiler usage, also could add a one time log warning (controlled by a local static bool), which warns if called without profiling support in binary

JoshEngebretson · 2017-06-23T17:56:26Z

The C# solution generator has support for adding constants, though not for debug vs release I don't think right now, example:

AtomicGameEngine/Script/AtomicNET/AtomicNETProject.json

Line 47 in a3cfc78

"defineConstants" : ["ATOMIC_DESKTOP"],

Would be a pretty easy add for supporting debug/release specific flags:

AtomicGameEngine/Source/ToolCore/NETTools/NETProjectGen.cpp

Line 473 in a3cfc78

    
           pgroup.CreateChild("DefineConstants").SetValue(String::Joined(constants, ";").CString());

JoshEngebretson · 2017-06-27T18:22:55Z

Script/AtomicNET/AtomicNET/Core/Profiler.cs

@@ -12,7 +12,7 @@ public partial class Profiler : AObject
                                 [CallerLineNumber] int line = 0)
        {
 #if ATOMIC_PROFILING
-            var profiler = GetSubsystem<Profiler>();
+            var profiler = AtomicNET.Context.GetProfiler();


When it is right, it is right, very 🐫 !

rokups · 2017-06-28T11:57:42Z

@JoshEngebretson i cleaned up commit history, now it is in a state to be merged. Updated easy_profiler to latest code on their develop branch too and all custom modifications are marked with atomic comments. The last bit missing is bit for js profiling.

JoshEngebretson

Very impressive work @rokups!!! I think we can get this landed in short order, I went through and did a final review with some comments. Let me know what you think, it is close, really close... a joy to review, A+ 😄

JoshEngebretson · 2017-06-28T12:18:18Z

Build/CMake/Modules/AtomicCommon.cmake

    setup_target()
+    if (ARG_TOOL)


Nice add and good standardization for tool bins 👍

JoshEngebretson · 2017-06-28T12:19:28Z

Script/AtomicNET/AtomicNET/Core/Profiler.cs

+        {
+#if ATOMIC_PROFILING
+            var profiler = AtomicNET.Context.GetProfiler();
+            if (profiler != null)


Still buzzing on new Context getters, great work there, it did make a Context.Profiler property too, right ;)

JoshEngebretson · 2017-06-28T12:20:19Z

Script/AtomicNET/AtomicNETProject.json

@@ -23,6 +23,7 @@
            "name": "AtomicNET",
            "atomicNET" : true,
            "outputType" : "Library",
+            "defineConstants" : ["ATOMIC_PROFILING"],


I think it is ok to define ATOMIC_PROFILING by default for now, we're going to want to be able to define difference constants per build, though that is for another day.

People would be profiling a release build anyhow, this flag missing on release builds would certainly cause some confusion.

I mean the equivalent of ${ATOMIC_RELEASE_OFF}, for release builds the ATOMIC_PROFILING define should default off in C#, no need to worry about it now.

JoshEngebretson · 2017-06-28T12:21:39Z

Source/Atomic/CMakeLists.txt

@@ -32,6 +32,7 @@ elseif (ATOMIC_DATABASE_ODBC)
 endif ()

 if (WIN32)
+    option (ATOMIC_D3D11 "Use DirectX 11" ON)


We're not quuuuite ready to switch the D3D11 switch on by default, is this doing that?

Not sure how that happened, will fix ;)

JoshEngebretson · 2017-06-28T12:25:01Z

Source/Atomic/CMakeLists.txt

-    target_compile_options(Atomic PUBLIC "$<$<CONFIG:Release>:${ATOMIC_MSVC_RUNTIME}>")
-    target_compile_options(Atomic PUBLIC "$<$<CONFIG:RelWithDebInfo>:${ATOMIC_MSVC_RUNTIME}>")
-    target_compile_options(Atomic PUBLIC "$<$<CONFIG:MinSizeRel>:${ATOMIC_MSVC_RUNTIME}>")
+    target_compile_options(Atomic PUBLIC $<$<CONFIG:Debug>:${ATOMIC_MSVC_RUNTIME}d> $<$<NOT:$<CONFIG:Debug>>:${ATOMIC_MSVC_RUNTIME}>)


Sometimes CMake makes my eyes cross, nice work

JoshEngebretson · 2017-06-28T12:58:06Z

Source/Atomic/Math/StringHash.cpp

@@ -43,20 +43,24 @@ const StringHash StringHash::ZERO;
 StringHash::StringHash(const char* str) :
    value_(Calculate(str))
 {
+#if ATOMIC_PROFILING
+    RegisterSignificantString(str, *this);
+#endif


What is the reason for registering all StringHash strings as being significant with profiling enabled?

We need this for being able to recognize event names. Events as you know are sent using StringHash, but profiler needs actual strings for data to be useful. See here.

Ok, this is definitely an area to keep an eye on, and maybe for future improvement. It registers every time a string is converted to a StringHash, ouch... I know this is the only way right now, hopefully this doesn't come up on the top of the profiler ;)

It it does, maybe we can introduce a separate ATOMIC_PROFILING_EVENTS for enabling event profiling...

JoshEngebretson · 2017-06-28T12:58:17Z

Source/Atomic/Math/StringHash.cpp

 }

 StringHash::StringHash(const String& str) :
    value_(Calculate(str.CString()))
 {
+#if ATOMIC_PROFILING
+    RegisterSignificantString(str, *this);


This one too, just noting...

JoshEngebretson · 2017-06-28T13:01:19Z

Source/Atomic/Resource/BackgroundLoader.cpp

@@ -264,20 +264,12 @@ void BackgroundLoader::FinishBackgroundLoading(BackgroundLoadItem& item)
    // If BeginLoad() phase was successful, call EndLoad() and get the final success/failure result
    if (success)
    {
-#ifdef ATOMIC_PROFILING
+#if ATOMIC_PROFILING


On these profiling changes, I don't think we need to pepper ATOMIC modification blocks everywhere, we've diverged... next update, I guess see what run into and maybe adjust, though think modification blocks would just add noise in these cases

This was reason why i did not add these comments elsewhere. We know that profiler subsystem was replaced therefore profiler changes should be ignored when merging from upstream. I am adding them to requested spots anyhow ;) Maybe we can find a way for got to help us do merges and make these comments thing of the past. I plan to look into it next ;)

JoshEngebretson · 2017-06-28T13:02:29Z

Source/Atomic/Resource/BackgroundLoader.cpp

-#ifdef ATOMIC_PROFILING
-        if (profiler)
-            profiler->EndBlock();
-#endif
    }


Another sign of code improvement, not needing to explicitly EndBlock, winning! 🏅

JoshEngebretson · 2017-06-28T13:04:30Z

Source/CMakeLists.txt

@@ -8,6 +8,7 @@ option(ATOMIC_EDITOR "Build Editor" ON)
 option(ATOMIC_DATABASE_SQLITE "Enable SQLite database subsystem" OFF)
 option(ATOMIC_DATABASE_ODBC "Enable ODBC database subsystem" OFF)
 option(ATOMIC_IK "Enable inverse kinematics subsystem" OFF)
+option(ATOMIC_PROFILING "Enable profiler" ${ATOMIC_RELEASE_OFF})


${ATOMIC_RELEASE_OFF} is very cool!

rokups · 2017-06-28T13:48:45Z

@JoshEngebretson requested changes landed. Once you review i will squash Changes requested in code review into easy_profiler integration in order to keep best appearances 👍

JoshEngebretson · 2017-06-28T13:55:48Z

Great, cleared for landing, I'll just do some final binary testing once you have the commits arranged, thanks!

JoshEngebretson · 2017-06-28T14:14:30Z

This would also be a good PR to add yourself to AUTHORS.md 🌟

rokups · 2017-06-28T15:27:45Z

Already there, Rokas Kupstys ;)

JoshEngebretson · 2017-06-28T15:34:05Z

Haha, awesome, you're a Super Contributor :) If you want to add yourself to the Atomic Game Engine credits block, I think you should.. and technically, part of the contributing agreement: CONTRIBUTING.md

…pects

Moved OpenGL config option to appropriate spot.

JoshEngebretson · 2017-06-28T20:21:12Z

@AtomicBuildBot retest this please

JoshEngebretson · 2017-06-28T22:19:42Z

Source/ThirdParty/easy_profiler/profiler_gui/CMakeLists.txt

+
+find_package(Qt5Widgets)
+
+if (NOT Qt5Widgets_FOUND)


This is supposed to be if (Qt5Widgets_FOUND)? I think a crumb may have been introduced when testing the warning message.

JoshEngebretson · 2017-06-28T23:31:00Z

@rokups I made some tweaks and added JS/TS Profiler.BeginBlock support, feel free to look over and cherry pick into PR: d826df8

I also had some problems on CI Mac, so:

@AtomicBuildBot retest this please

…ort and TypeScript decl

JoshEngebretson · 2017-06-29T16:17:06Z

@rokups You absolutely shredded on the new Profiler subsystem 🎸 , very impressive work! It has also been a lot of fun working on this feature with you, LEVEL UP! 🌟

A hearty THANKS from 🐫 everywhere, and special thanks to @cas4ey for such an excellent profiling library and client, which Atomic now uses to profile C++, C#, JavaScript/TypeScript!!!

LANDING! ✈️

Type1J · 2017-06-29T16:19:36Z

This is pretty awesome @rokups!

cas4ey · 2017-06-30T15:05:41Z

Whoa! Great news! 👍
@rokups Thanks for your great work on the integration and for your valuable suggestions for easy_profiler 🥇
@JoshEngebretson It's a pleasure to create useful things which could help people 😃

rokups mentioned this pull request Apr 29, 2017

Design problem with StackBuffer yse/easy_profiler#37

Closed

JoshEngebretson reviewed Jun 15, 2017

View reviewed changes

JoshEngebretson reviewed Jun 19, 2017

View reviewed changes

JoshEngebretson reviewed Jun 23, 2017

View reviewed changes

JoshEngebretson reviewed Jun 27, 2017

View reviewed changes

JoshEngebretson reviewed Jun 28, 2017

View reviewed changes

rokups added 6 commits June 28, 2017 21:05

easy_profiler third party dependency deleted old profiler code

b7d42c8

easy_profiler integration

cef1940

Simplify exporting msvc runtime flag

75fc862

Added Color::ToUIntArgb() for converting colors to format profiler ex…

d24c488

…pects

Fix d3d9 quirk on first build.

30ee01c

Moved OpenGL config option to appropriate spot.

Make me famous

ac8bc4a

JoshEngebretson reviewed Jun 28, 2017

View reviewed changes

JoshEngebretson and others added 2 commits June 28, 2017 16:58

A few tweaks and Qt5 package fix, adding JS Profiler::BeginBlock supp…

d826df8

…ort and TypeScript decl

Static profiler BeginBlock and EndBlock methods for c#

bedf501

JoshEngebretson merged commit 0c52b46 into AtomicGameEngine:master Jun 29, 2017

rokups deleted the feature/easy_profiler branch June 29, 2017 17:30

easy_profiler integration #1531

easy_profiler integration #1531

Conversation

rokups commented Apr 28, 2017 • edited by JoshEngebretson

JoshEngebretson commented May 16, 2017

JoshEngebretson commented May 16, 2017 • edited

JoshEngebretson commented May 16, 2017

rokups commented Jun 6, 2017

JoshEngebretson commented Jun 6, 2017

cas4ey commented Jun 11, 2017

JoshEngebretson commented Jun 11, 2017 • edited

rokups commented Jun 12, 2017 • edited

JoshEngebretson commented Jun 12, 2017 • edited

rokups commented Jun 13, 2017

JoshEngebretson commented Jun 13, 2017

JoshEngebretson commented Jun 13, 2017

rokups commented Jun 14, 2017

JoshEngebretson Jun 15, 2017 • edited

Choose a reason for hiding this comment

rokups commented Jun 15, 2017

rokups commented Jun 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rokups commented Jun 22, 2017

JoshEngebretson commented Jun 22, 2017

HeadClot commented Jun 23, 2017

Type1J commented Jun 23, 2017

rokups commented Jun 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshEngebretson Jun 23, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshEngebretson commented Jun 23, 2017

Choose a reason for hiding this comment

rokups commented Jun 28, 2017

JoshEngebretson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rokups commented Jun 28, 2017

JoshEngebretson commented Jun 28, 2017

JoshEngebretson commented Jun 28, 2017

rokups commented Jun 28, 2017

JoshEngebretson commented Jun 28, 2017

JoshEngebretson commented Jun 28, 2017

Choose a reason for hiding this comment

JoshEngebretson commented Jun 28, 2017 • edited

JoshEngebretson commented Jun 29, 2017 • edited

Type1J commented Jun 29, 2017

cas4ey commented Jun 30, 2017

rokups commented Apr 28, 2017 •

edited by JoshEngebretson

JoshEngebretson commented May 16, 2017 •

edited

JoshEngebretson commented Jun 11, 2017 •

edited

rokups commented Jun 12, 2017 •

edited

JoshEngebretson commented Jun 12, 2017 •

edited

JoshEngebretson Jun 15, 2017 •

edited

JoshEngebretson Jun 23, 2017 •

edited

JoshEngebretson commented Jun 28, 2017 •

edited

JoshEngebretson commented Jun 29, 2017 •

edited