Reduce vulnerabilities with Loans contract init race conditions #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjablack
force-pushed
the
6.22-loans-init-race-condition
branch
from
f9407bf
to
bbbfdb8
Compare
matthewjablack
force-pushed
the
6.22-loans-init-race-condition
branch
from
bbbfdb8
to
c406877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces vulnerabilities with
Loanscontract init race conditions.setSalesis used to set theLoanscontract address after deployment. This PR this can only be called by the original deployer, and can only be called once.Similar to: #30
Submission Checklist 📝
setSalescan only be called by deployer and only called oncesetSalescan't be called twice.