-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Not 100% compatible with "Enchanted Shulkers" #64
Comments
I didn't notice this bug report, but just reported it/requested compatibility on Enchanted Shulkers' Github and then came over here to see if anyone else had the same problem. In my testing, which was using Siphon, not Refill, the magic number was 27, not 21 though. 27 is the normal max capacity of a shulker box. I also found that the two mods working together would destroy items after the normal capacity of a shulker box. I see that you two mod authors have worked together before, so hopefully you guys are still working together. Server JAR: fabric-server-mc.1.19.2-loader.0.14.19-launcher.0.11.2.jar Client mod list:``` (Fabric)GlowInkPlus-1.19.x-1.2.0.jar |
It seems like the EnchantedShulkers mod is always setting the inventory size of Shulker Boxes to 27. If this is the case, I can't fix this issue with my mod. |
The other day I went looking for code to that effect, but didn't find it.
I'll take a look at that java file and see if I can lend a helping hand, might even try to commit something to Github for the first time.
Dan Whaley, MCP, RVC-E, DMC-E-4K, DMC-S, CTS
OIF II Veteran, USMC
Threema is preferred and secure: VKTCXSPJ
***@***.***
LinkedIn | Github | Thingiverse | Stack Overflow
…On Sep 7, 2023, 10:24 AM, at 10:24 AM, Aton-Kish ***@***.***> wrote:
It seems like the EnchantedShulkers mod is always setting the inventory
size of Shulker Boxes to 27. If this is the case, I can't fix this
issue with my mod.
https://github.com/RubixDev/EnchantedShulkers/blob/6fa8e84ff599d60e56c779195b7ae8927915ffb0/src/main/java/de/rubixdev/enchantedshulkers/Utils.java#L61
--
Reply to this email directly or view it on GitHub:
#64 (comment)
You are receiving this because you commented.
Message ID:
***@***.***>
|
Do you have a get method to get your shulkerbox size? |
Related issue in Enchanted Shulkers repo: RubixDev/EnchantedShulkers#24 |
Also this is a duplicate of #51 least in name, topic is not related at all) |
This issue is fixed on my side now |
Describe the bug
When you enchant a Netherite Reinforced Shulker with either "Refill" or "Siphon" it does work but only for 21 slots. What this means is that for example if I have a Netherite Reinforced Shulker enchanted with "Refill" filled with full stacks of Scafolding and then use the scafolding, the shulker will refill my stack in hand but will also delete all the stacks of scafolding in it's inside except 27 of them. This also happens with the "Siphon" enchantment. It works just not beyong 27 stacks AKA a normal shulkerbox.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected the items in the shulkerbox to remain without being deleted automatically by using the enchatment. Meaning if I had a "Netherite Reinforced Shulker" with the "Refill" enchatment and filled it's 108 slots with full stacks of dirt to then only use a stack of dirt, when I opened back the shulker there should be 107 stacks not 20.
Screenshots
This is a screenshot of the mods I was using.
![115831](https://private-user-images.githubusercontent.com/81993061/264740383-7e74597c-8d11-4777-a621-ca99ab4e37a6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3ODAxNzksIm5iZiI6MTcyNTc3OTg3OSwicGF0aCI6Ii84MTk5MzA2MS8yNjQ3NDAzODMtN2U3NDU5N2MtOGQxMS00Nzc3LWE2MjEtY2E5OWFiNGUzN2E2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA4VDA3MTc1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhMGE5ODExYjg3NjhhYWViODI1ZWU2Yjg5Y2I2OTg4MGVlM2VmNGVjZWI4ZWIzNWVmZGNiZDg3MzhlYzI3OTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cdNMbdxvxlIVpyvmmy52ZOsUomhbdPKJqAXPNvtJtQI)
Although originally I was using more mods I decided to test it bare bones to see if it was an incompatibility issue but apparently it isn't
Environment
According to me this is the envirorment where I'm using the mod:
This is the name of the file of your mod: reinforced-shulker-boxes-2.2.0+1.19
This is what your mod says in the manifest:
Manifest-Version: 1.0
Fabric-Gradle-Version: 7.4
Fabric-Loom-Version: 1.0.11
Fabric-Mixin-Compile-Extensions-Version: 0.5.0
Fabric-Minecraft-Version: 1.19.2
Fabric-Tiny-Remapper-Version: 0.8.5
Fabric-Loader-Version: 0.14.9
Fabric-Mixin-Version: 0.11.4+mixin.0.8.5
Fabric-Mixin-Group: net.fabricmc
Fabric-Mapping-Namespace: intermediary
Also the version of the enchanted shulkers mod is this one or well the name of the file anw: enchantedshulkers-1.0.4+1.19
I download it from curseforge.
Logs
I don't know what this is but let me know and I'll provided if need it.
Additional context
Here's a video of me demostrating the issue. https://gofile.io/d/SlMb2V
The text was updated successfully, but these errors were encountered: