Skip to content

Commit

Permalink
fix(loraserver.io #70): MQTT topics updated to versions after v1
Browse files Browse the repository at this point in the history
  • Loading branch information
dcalvoalonso committed Jun 13, 2019
1 parent c92c7f4 commit 6e40ec9
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
8 changes: 4 additions & 4 deletions lib/applicationServers/loraserverioAppService.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class LoraserverIoService extends appService.AbstractAppService {
throw new Error('Missing mandatory configuration attributes for lorawan:dev_eui');
}

var mqttTopic = 'application/' + this.applicationId + '/node/' + devEUI.toLowerCase() + '/rx';
var mqttTopic = 'application/' + this.applicationId + '/device/' + devEUI.toLowerCase() + '/rx';
this.mqttClient.subscribeTopic(mqttTopic);
winston.info('Mqtt topic subscribed:%s', mqttTopic);
}
Expand All @@ -153,7 +153,7 @@ class LoraserverIoService extends appService.AbstractAppService {
* @param {<type>} deviceObject The device object
*/
stopObservingDevice(devId, devEUI, deviceObject) {
var mqttTopic = 'application/' + this.applicationId + '/node/' + devEUI.toLowerCase() + '/rx';
var mqttTopic = 'application/' + this.applicationId + '/device/' + devEUI.toLowerCase() + '/rx';
this.mqttClient.unSubscribeTopic(mqttTopic);
winston.info('Mqtt topic unsubscribed:%s', mqttTopic);
}
Expand All @@ -162,7 +162,7 @@ class LoraserverIoService extends appService.AbstractAppService {
* It observes all devices
*/
observeAllDevices() {
var mqttTopic = 'application/' + this.applicationId + '/node/+/rx';
var mqttTopic = 'application/' + this.applicationId + '/device/+/rx';
this.mqttClient.subscribeTopic(mqttTopic);
winston.info('Mqtt topic subscribed:%s', mqttTopic);
}
Expand All @@ -171,7 +171,7 @@ class LoraserverIoService extends appService.AbstractAppService {
* It stops observing all devices.
*/
stopObserveAllDevices() {
var mqttTopic = 'application/' + this.applicationId + '/node/+/rx';
var mqttTopic = 'application/' + this.applicationId + '/device/+/rx';
this.mqttClient.unSubscribeTopic(mqttTopic);
winston.info('Mqtt topic unsubscribed:%s', mqttTopic);
}
Expand Down
8 changes: 4 additions & 4 deletions test/unit/deviceProvisioningLoRaServerIo.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ describe('Device provisioning API: Provision devices', function() {
client.publish(
'application/' +
options.json.devices[0]['internal_attributes']['lorawan']['application_id'] +
'/node/' +
'/device/' +
options.json.devices[0]['internal_attributes']['lorawan']['dev_eui'].toLowerCase() +
'/rx',
JSON.stringify(attributesExample)
Expand Down Expand Up @@ -240,7 +240,7 @@ describe('Device provisioning API: Provision devices', function() {
client.publish(
'application/' +
options.json.devices[0]['internal_attributes']['lorawan']['application_id'] +
'/node/' +
'/device/' +
options.json.devices[0]['internal_attributes']['lorawan']['dev_eui'].toLowerCase() +
'/rx',
JSON.stringify(attributesExample)
Expand All @@ -266,7 +266,7 @@ describe('Device provisioning API: Provision devices', function() {
var attributesExample = utils.readExampleFile('./test/activeAttributes/cayenneLpp_bad_json.json', true);
var client = mqtt.connect('mqtt://' + testMosquittoHost);
client.on('connect', function() {
client.publish('application/1/node/3339343752356A14/rx', JSON.stringify(attributesExample));
client.publish('application/1/device/3339343752356A14/rx', JSON.stringify(attributesExample));
setTimeout(function() {
client.end();
done();
Expand All @@ -281,7 +281,7 @@ describe('Device provisioning API: Provision devices', function() {
);
var client = mqtt.connect('mqtt://' + testMosquittoHost);
client.on('connect', function() {
client.publish('application/1/node/3339343752356A14/rx', JSON.stringify(attributesExample));
client.publish('application/1/device/3339343752356A14/rx', JSON.stringify(attributesExample));
setTimeout(function() {
client.end();
done();
Expand Down
6 changes: 3 additions & 3 deletions test/unit/groupProvisioningLoRaServerIo.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe('Configuration provisioning API: Provision groups', function() {
client.publish(
'application/' +
options.json.services[0]['internal_attributes']['lorawan']['application_id'] +
'/node/' +
'/device/' +
attributesExample.devEUI +
'/rx',
JSON.stringify(attributesExample)
Expand Down Expand Up @@ -218,7 +218,7 @@ describe('Configuration provisioning API: Provision groups', function() {
client.publish(
'application/' +
options.json.services[0]['internal_attributes']['lorawan']['application_id'] +
'/node/' +
'/device/' +
attributesExample.devEUI +
'/rx',
JSON.stringify(attributesExample)
Expand Down Expand Up @@ -300,7 +300,7 @@ describe('Configuration provisioning API: Provision groups', function() {
client.publish(
'application/' +
options.json.services[0]['internal_attributes']['lorawan']['application_id'] +
'/node/' +
'/device/' +
attributesExample.devEUI +
'/rx',
JSON.stringify(attributesExample)
Expand Down
2 changes: 1 addition & 1 deletion test/unit/staticProvisioningLoRaServerIo.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ describe('Static provisioning', function() {
client.publish(
'application/' +
sensorType['internalAttributes']['lorawan']['application_id'] +
'/node/' +
'/device/' +
attributesExample.devEUI +
'/rx',
JSON.stringify(attributesExample)
Expand Down

0 comments on commit 6e40ec9

Please sign in to comment.