Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves documentation #45

Merged
merged 9 commits into from
Jan 24, 2019
Merged

Improves documentation #45

merged 9 commits into from
Jan 24, 2019

Conversation

dcalvoalonso
Copy link
Collaborator

@dcalvoalonso dcalvoalonso commented Jan 24, 2019

Fixes #42 and #41

@dcalvoalonso dcalvoalonso changed the title Fixes #42 Improves documentation Jan 24, 2019
@dcalvoalonso
Copy link
Collaborator Author

@jason-fox Could you please review before merging?

Copy link
Contributor

@jason-fox jason-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM, one further is change necessary

  • docs/installationguide.md needs to be added to the mkdocs.yml

@dcalvoalonso
Copy link
Collaborator Author

Fixed with 4c12f9a

@dcalvoalonso dcalvoalonso merged commit ac9f919 into master Jan 24, 2019
@jason-fox
Copy link
Contributor

@dcalvoalonso - it looks like something weird has gone on with themkdocs.yml file - the additional pages appear to have been added and then removed. They are not appearing in the latest docs. could you check?

@dcalvoalonso
Copy link
Collaborator Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@chicco785 chicco785 deleted the docs/requirements branch April 11, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants