Align prettier settings and eslint #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-fox
commented
Jan 31, 2019
| @@ -5,8 +5,9 @@ | |||
| "extends": "standard", | |||
| "rules": { | |||
| "semi": [2, "always"], | |||
| "indent": ["error", 4], | |||
| "mocha/no-exclusive-tests": "error" | |||
| "indent": 0, | |||
There was a problem hiding this comment.
Rule switched of since indent doesn't always agree with prettier decisions, particularly for very long lines.
jason-fox
commented
Jan 31, 2019
| "mocha/no-exclusive-tests": "error" | ||
| "indent": 0, | ||
| "mocha/no-exclusive-tests": "error", | ||
| "space-before-function-paren": 0 |
There was a problem hiding this comment.
The space-before-function-paren rule conflicts with standard prettier formatting which consistently doesn't add the space.
jason-fox
commented
Jan 31, 2019
| "singleQuote": true, | ||
| "parser": "flow", | ||
| "printWidth": 120, | ||
| "trailingComma": "none", |
There was a problem hiding this comment.
Your eslint config was complaining about trailing commas, so I've switched it off here
jason-fox
added a commit
to jason-fox/IoTagent-LoRaWAN
that referenced
this pull request
Feb 1, 2019
* master: Align prettier settings and eslint (Atos-Research-and-Innovation#49)
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous PR #47 - I broke your linting rules. This fixes the issue by either amending the prettier config or the eslint config so that they match.
It shouldn't be an issue going forward as prettier will do its thing on commit, I've also added the linter to the travis CI so that this gets picked up properly.