Eliminate duplicate nouns and add unit tests to check for this issue #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….2 at this time).
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 4 4
===========================================
Files 1 1
Lines 14 14
===========================================
Hits 14 14
Continue to review full report at Codecov.
|
|
Thank you @Sandyman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed duplicate nouns 'sun' and 'water'. I have also added unit tests to prevent this from happening again. In addition, I have removed the obsolete option 'syntaxCheck' from
phpunit.xml.On top of that, I have updated the minimum version to the last (only just) supported version, which at this time is 7.2.