New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Graph SLAM documentation and SE(2) example #302
Conversation
@JeffLIrion Your doc looks great!!. Please keep working it : ). |
This pull request introduces 1 alert when merging 4e2d7a8 into 869650f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging a12b675 into 869650f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 6ebdb42 into 869650f - view on LGTM.com new alerts:
|
Current status
Any other tasks that you'd like to see completed? |
Thank you for your hard work!!. That is OK. Please let me know when you are ready to start to review. |
This is ready to start the review process! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your big work. I have several questions.
- This repo already have graph_based_slam.py. is your code using same algorithm?
- Do you want to keep latex codes and pdf? is it impossible to use jupyter notebook to describe math?
- You added images in the image dir. Are these impossible to embedded a jupyter notebook?
|
For my own reference:
|
Do you think it is possible for you to update the graph_based_slam.py using your solver? |
OK. I got it. |
Oh. great. Please remove the pngs. I want to keep the PR as simple as possible. |
Done. I left only the .gif image. |
I'm sure it's possible, but my wife and I just had a baby, so I simply don't have the time to do that right now. Sorry. |
OK. Thank you so much.
No problem. Is it ok to merge this PR now? Maybe I can do it later. |
I'll squash my commits and then it will be ready. |
I squashed the commits, so this is ready to be merged. |
@JeffLIrion Thank you so much for your great work. More PRs are always welcome!! |
This is a work in progress.
The Jupyter notebook doesn't render correctly on GitHub, so I moved the write-up into a LaTeX file and included both the .tex source and the generated PDF. I'll probably remove it altogether from the Jupyter notebook.
TODO: Add code and example problem
Related issue: #296