Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change PF resampling function to match with the book #245

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

goktug97
Copy link
Contributor

  • changed resampling function so that it chooses random number once for the starting point.
  • condition check is moved from the inside of the resampling function
    to the outside of the function, this way the purpose of the
    function is much clear. Instead "resampling" every iteration,
    resample if the condition holds.

- changed resampling function so that it chooses random number once for the starting point.
- condition check is moved from the inside of the resampling function
to the outside of the function, this way the purpose of the
function is much clear. Instead "resampling" every iteration,
resample if the condition holds.
@goktug97 goktug97 changed the title change resampling function to match with the book change PF resampling function to match with the book Oct 26, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1057

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.341%

Files with Coverage Reduction New Missed Lines %
PathPlanning/ClosedLoopRRTStar/pure_pursuit.py 1 95.35%
PathPlanning/BatchInformedRRTStar/batch_informed_rrtstar.py 5 81.41%
Totals Coverage Status
Change from base Build 1051: -0.01%
Covered Lines: 6734
Relevant Lines: 7454

💛 - Coveralls

@AtsushiSakai
Copy link
Owner

@goktug97 Thank you so much again!!. You are totally right. your code looks better. I will merge it.

@AtsushiSakai AtsushiSakai merged commit 5b2f86d into AtsushiSakai:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants