Bug fixes for OpenSimplex2S Noise 2D (GLSL) and Value Cubic Noise 3D (GLSL and HLSL) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In GLSL version OpenSimplex2S2D was divided into rhombic fragments. This fix was based on HLSL version code, that has no fragmentation bug: see https://github.com/Auburn/FastNoiseLite/blob/df34389c6b3cbba88fd7caf9d376587ebcb31522/HLSL/FastNoiseLite.hlsl#L1059C22-L1059C22
In GLSL version ValueCubic3D produced values that was outside of default color ramp. This fix was based on C++ version code, that has no contrast bug: see https://github.com/Auburn/FastNoiseLite/blob/df34389c6b3cbba88fd7caf9d376587ebcb31522/Cpp/FastNoiseLite.h#L1914
In HLSL version ValueCubic3D produced values that was outside of default color ramp. This fix was based on C++ version code, that has no contrast bug: see https://github.com/Auburn/FastNoiseLite/blob/df34389c6b3cbba88fd7caf9d376587ebcb31522/Cpp/FastNoiseLite.h#L1914
MAGGen-hub
changed the title
|
Thanks, fixes look good 👍 |
|
Thank you, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear developers of FastNoiseLite Libruary.
I am working on custom plugin for Godot Game Engine that will allow usage of FastNoiseLite libruary on GPU device to provide noise data at runtime without visible delays and freezes.
I runned some tests in Godot and Shadertoy and found a few bugs in
_fnlSingleOpenSimplex2S2D(In GLSL version only) and_fnlSingleValueCubic3D(In GLSL and HLSL versions) functions.OpenSimplex2S Noise 2D (GLSL) before bug fix:
After bug fix:
Value Cubic Noise 3D (GLSL) before bug fix:
After bug fix (equal to output of C++ and https://auburn.github.io/FastNoiseLite/ versions):
According to my current tests - other Noises (and functions) in GLSL are 99.9% equal to Noises created by C++ version of FastNoiseLite provided by Godot:
If I found more bugs during plugin development I will try to inform you about them and seek for posible solutions...
Thank you for your attention and sorry for my bad English. Good luck in future development.
P.S. : Code I created for Shadertoy(https://www.shadertoy.com/) for testing and demonstration:
FastNoiseLite-ShadertoyTest.txt