Skip to content
This repository has been archived by the owner on May 16, 2021. It is now read-only.

Enter key pressed on form's input or textarea doesn't work #280

Closed
earvinbryanco opened this issue Feb 1, 2013 · 15 comments
Closed

Enter key pressed on form's input or textarea doesn't work #280

earvinbryanco opened this issue Feb 1, 2013 · 15 comments

Comments

@earvinbryanco
Copy link

I can't submit a form when I press "enter" on keyboard. I think there's something wrong with the plugin. I have to click on the button just to be able to submit the form itself. I've tried creating a new blank document with a simple form and with the plugin, still doesn't work. I'm not using any validations at all.

Also, another comment is on the theme. Try hovering the cursor to the button, you'll see an extra outline on the left side of the button. I think this is from the images itself.

Thanks!

@fidian
Copy link
Collaborator

fidian commented Feb 1, 2013

Could you post a sample page to help illustrate the point? Or maybe a screen shot of the demo page or the project's homepage that shows off the problems?

What browser are you using?

@earvinbryanco
Copy link
Author

Anyway, found the issue on the enter key. But I'll keep on checking. For the default theme, I've tried them on all major browsers already. got the same result, I think it's in the image itself. Here's a screenshot.
Untitled-1

@earvinbryanco
Copy link
Author

Now I get it, when you place your input tags inside a table tag, hitting the enter key wouldn't work. Is there a work around for this one? Thanks! Tried it on all browsers already.

@earvinbryanco
Copy link
Author

More inputs here, if you're styling one input within a table, there's no issue. But when you add more rows and inputs, that's where the issue (enter key to submit) comes in.

@exside
Copy link

exside commented Feb 4, 2013

I think the relevant code starts at line 489, I don't see a keyup or whatever event bound to buttons, submits etc., does it work at all (mean outside of a table markup...)? Probably...because it's default behaviour. Not sure why it isn't with table markup...but if you can, just dont use a table to markup a form =D

@earvinbryanco
Copy link
Author

I not sure either. I've tested it on IE9, chrome, and firefox. All of it doesn't work. BUT, it works on 3.6.28 (I think) sometimes it works, sometimes it doesn't

@fidian
Copy link
Collaborator

fidian commented Feb 5, 2013

I don't watch for pressing the enter key in forms. The form should submit normally with or without styling. If that is not the case, a demo page to show off the problem is vital. It seems to work well for me - see my test page at https://gist.github.com/fidian/4714897

As to the second issue, that's been bugging me too. I'll dive into that more today.

fidian added a commit that referenced this issue Feb 5, 2013
@fidian
Copy link
Collaborator

fidian commented Feb 5, 2013

Found the problem for the image not looking right. The change is currently on the master branch, as I am trying to release 2.1.0 today.

So now we just need to figure out what's going on with pressing enter in forms in a table. Let me know when you get a demo page working or if you can show me your current page.

@earvinbryanco
Copy link
Author

Yeay! Thanks for that!

Would you like me to upload a sample of the codes I'm using for the table? I've actually tried it also using divs, same issue. When you style a input and a button there's no problem at all. but when you have like 4 or 5 inputs already, then that's when the issue comes in. I can provide a link with the files I have so that I can help you look for some of the issues. I'll provide a link for you within today. Thanks!

@fidian
Copy link
Collaborator

fidian commented Feb 7, 2013

Yes, I would love to have a jsfiddle or a sample HTML page that illustrates the problem.

@fidian
Copy link
Collaborator

fidian commented Feb 12, 2013

Is there anything I can see to show off this problem?

@earvinbryanco
Copy link
Author

Here's the link.

http://staging.earvinbryan.com/uniform/

Sorry for the super late reply.

@fidian
Copy link
Collaborator

fidian commented Feb 19, 2013

It turns out that submit buttons don't work when you use display: none with them. Changing them to display: block and set a minimum amount of opacity. This is committed in the develop branch - please let me know if this works for you.

@earvinbryanco
Copy link
Author

YEAY! It worked! By the way where can I get the latest default theme image?

@earvinbryanco
Copy link
Author

Oh, never mind, saw it already thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants