This repository has been archived by the owner on May 16, 2021. It is now read-only.
Inherit classes #80
Labels
Comments
|
interesting point. I suppose I could grab the classes straight from the child element. Would it be useful to remove the class from child element once it's been uniformed? |
|
hmm tough call there, I would imagine that would be fine. I also noticed that if I replace a button I cant tab to it from a form, but that is probably for another issue |
ericfreese
added a commit
to ericfreese/uniform
that referenced
this issue
Feb 21, 2013
…ginal input elements
Applies to:
- select (non-multiline)
- radio
- checkbox
- file input
Has the side effect that there is now no way to specify a class to be left on the original select or input element.
A few possible solutions:
- Leave the class on the element all the time
- Could result in style conflicts (i.e. styling meant for wrapper div also applies to hidden select/input element.
- Add an option to either leave the class on or remove it.
- Take the classes off, but rename them with "uniform-" prefix, similar to how id's are inherited.
- Use a data attribute such as "data-uniform-class" to specify classes that should be added to the wrapper div
- Wouldn't work with jQuery < 1.4.3
- Would require different class definitions for regular inputs that don't use wrapper divs and inputs that do (i.e. class vs. data-uniform-class)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If I have the class "right" on a button should it not be on the generated element too?
The text was updated successfully, but these errors were encountered: