CN Reconfig mode primary only override (#4161)

AudiusProject · Oct 25, 2022 · b1cfbcb · b1cfbcb
1 parent 59b086a
commit b1cfbcb
Show file tree

Hide file tree

Showing 4 changed files with 459 additions and 22 deletions.
diff --git a/creator-node/package-lock.json b/creator-node/package-lock.json
diff --git a/creator-node/src/config.js b/creator-node/src/config.js
@@ -445,6 +445,12 @@ const config = convict({
     env: 'snapbackHighestReconfigMode',
     default: 'PRIMARY_AND_OR_SECONDARIES'
   },
+  reconfigModePrimaryOnly: {
+    doc: 'Override for `snapbackHighestReconfigMode` to only reconfig primary from replica set',
+    format: Boolean,
+    env: 'reconfigModePrimaryOnly',
+    default: false
+  },
   devMode: {
     doc: 'Used to differentiate production vs dev mode for node',
     format: 'BooleanCustom',

diff --git a/...ode/src/services/stateMachineManager/stateReconciliation/updateReplicaSet.jobProcessor.ts b/...ode/src/services/stateMachineManager/stateReconciliation/updateReplicaSet.jobProcessor.ts
@@ -40,6 +40,9 @@ const reconfigNodeWhitelist = config.get('reconfigNodeWhitelist')
   : null
 
 const RECONFIG_SP_IDS_BLACKLIST: number[] = config.get('reconfigSPIdBlacklist')
+const RECONFIG_MODE_PRIMARY_ONLY: Boolean = config.get(
+  'reconfigModePrimaryOnly'
+)
 
 /**
  * Updates replica sets of a user who has one or more unhealthy nodes as their primary or secondaries.
@@ -820,6 +823,15 @@ const _issueUpdateReplicaSetOp = async (
  */
 const _isReconfigEnabled = (enabledReconfigModes: string[], mode: string) => {
   if (mode === RECONFIG_MODES.RECONFIG_DISABLED.key) return false
+
+  // If primary only override is enabled, only issue reconfig if mode is in enabled modes set and indicates a primary reconfig
+  if (RECONFIG_MODE_PRIMARY_ONLY) {
+    return (
+      enabledReconfigModes.includes(mode) &&
+      mode === RECONFIG_MODES.PRIMARY_AND_OR_SECONDARIES.key
+    )
+  }
+
   return enabledReconfigModes.includes(mode)
 }