Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check duration query param validation #1014

Merged
merged 1 commit into from Oct 30, 2020

Conversation

SidSethi
Copy link
Contributor

Trello Card Link

Description

Services

  • Discovery Provider
  • Creator Node
  • Identity Service
  • Libs
  • Contracts
  • Service Commands
  • Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • 🚨 Yes, this touches
  • ✅ Nope

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

  1. Test 1
  • Step 1
  • Step 2
  • Step 3

Please list the unit test(s) you added to verify your changes.

  1. Unit test 1

@SidSethi SidSethi merged commit fb0040b into master Oct 30, 2020
@SidSethi SidSethi deleted the ss-healthcheck-duration-fix branch October 30, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants