Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update health check return values #1028

Merged
merged 2 commits into from Nov 3, 2020
Merged

Update health check return values #1028

merged 2 commits into from Nov 3, 2020

Conversation

dmanjunath
Copy link
Contributor

Trello Card Link

None

Description

Change these default values returned from health check

Services

  • Discovery Provider
  • Creator Node
  • Identity Service
  • Libs
  • Contracts
  • Service Commands
  • Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • ✅ Nope

How Has This Been Tested?

Ran the system locally and verified the output

Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find with this one, we can confirm that the path isn't weird for whatever reason and mounted as expected w/PVC

creator-node/src/routes/healthCheck.js Outdated Show resolved Hide resolved
@dmanjunath dmanjunath merged commit b2c595d into master Nov 3, 2020
@dmanjunath dmanjunath deleted the dm-sp-healthchecks branch November 3, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants