User/Track update ipfs bug fix

[SidSethi]

Trello Card Link

https://trello.com/c/wQ26N0RE

Description

Replace ipfs validation with disk validation in user/track update flows, add ipfs + disk validation during image upload

Problem: currently, anytime someone updates user or artist data, CN performs validation on associated images. the function that performed this validation, getFileUUIDForImageCID() would call ipfs.cat() and ipfs.ls() on the image dir CIDs with no timeouts or try-catch. this is bad for many reasons, and likely the primary cause for repeated /audius_users calls timing out at 10min

Solution: On a state update, we should do minimal validation, and move the heavy-weight validation to first time upload to guarantee correctness before returning to user and writing CID to chain. image upload now performs a full byte-level validation of the files written to disk. user updates now perform a much lighter disk/db check.

Services

• Discovery Provider
• Creator Node
• Identity Service
• Libs
• Contracts
• Service Commands
• Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

• 🚨 Yes, this touches cnode track + user update (not upload) and image upload

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.

1. all existing CN unit and integration tests
2. maddog test
3. e2e manual testing via dapp: signup, upload, sync, failover, user update, track update
4. perf test: measure route duration for /audius_users and /tracks, pull ensurePrimaryMiddleware duration from logs and subtract. on staging i'm repeatedly observing ~0.25s which is fantastic

Please list the unit test(s) you added to verify your changes.

[dmanjunath]

Some questions but the one I have some follow up q's on is what do we do in validateStateForImageDirCIDAndReturnFileUUID in the case of a non dir image? it seems like that flow is broken currently as well cause that would error?

[SidSethi]

Fix ipfs image bug

[hareeshnagaraj]

Let's go, this looks great