Remerge cnode selection #1076
Merged
Remerge cnode selection #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add creator node selection class + unit tests * update comments + fix code/test * update test * pick a cnode based on version, then responsetime * resolve comments from cn pr * excuse me vscode y didnt u tell me there was a merge conflict * change let to const * remove this.state + refactor filtering services for secondaries * remove geographic data for now since not using * update decision tree to sentence case + add back geo location * update test
…tead in checking health
raymondjacobson
approved these changes
Nov 24, 2020
dmanjunath
approved these changes
Nov 24, 2020
raymondjacobson
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/eVKqXcKS/1639-add-creator-node-selection-logic
Description
On 11/16/2020, the original, updated Content Node selection PR was reverted. This was because although the new selection logic in libs had been published and released, the selection logic also relied on some new fields in Content Node's
/health_checkroute that was also included in the original PR. However, the Content Node was not released with the new data in the/health_checkroute. This caused the cnode selection to fail, and thus preventing uploads from successfully working.The purpose of this PR is to:
/health_checkfor the geographic location. We will instead check for/version, as this endpoint already contains the version info and geographic info./health_check/verboseto include the original/health_checkdata, as well as geographic data./versionServices
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Include log analysis if applicable.
libs-1.0.0Unit Tests:
Please refer to PR.