Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use IPFS client 0.33.1 for rehydrate images #1285

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

hareeshnagaraj
Copy link
Contributor

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Standardize ipfs-http-client across resizeImage.js and in rehydrate function, ensuring equivalent output. Prior to this fix, all rehydrate directory image add operations were failing silently.

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

  1. Upload image to local setup
  2. Kill ipfs nodes 1, 2
  3. Attempt to ipfs ls <imageCID and confirm failure (hangs indefinitely)
  4. Initiate rehydrate by visiting http://cn1_creatornode_1:4000/ipfs/<CID>/2000x.jpg
  5. Confirm addResp succeeds in rehydrate flow
[2021-03-09T02:16:37.725Z]  INFO: audius_creator_node/51 on 1df6f3eb4273: rehydrateIpfsFromFsIfNecessary - addResp
[{"path":"blob/original.jpg","hash":"QmUXVqzy9DubDaJ15F4mZ97yTbeSFWREjGeBinCKcPpPxs","size":92882}
,{"path":"blob/2000x.jpg","hash":"QmVy7AC7ZtVvj4aNAa8U23rmb9zBCwbQfbAgZGiiKLDZ7o","size":38380}
,{"path":"blob/640x.jpg","hash":"QmQ7uDq4nCrHAHE7XPBEXF3sn6vvLXQGYqfERwr5yi9oJN","size":19603}
,{"path":"blob","hash":"QmYummbpXAEAshxUozow3XsYf7VojpCU4k2p2kb3WBTB6N","size":151030}] (requestID=-EjEd9K1T,
 requestMethod=GET, requestHostname=cn1_creator-node_1)

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@vicky-g vicky-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@hareeshnagaraj hareeshnagaraj merged commit 7ec9255 into master Mar 9, 2021
@hareeshnagaraj hareeshnagaraj deleted the hn_rehydrate_fix branch March 9, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants