Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trending track last completion to health check #1294

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

raymondjacobson
Copy link
Member

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Add a health check field for the last time trending indexed.

I thought a bunch about where to put this -- options being:

  1. health check
  2. new trending_check
  3. play_check

I ultimately felt that 1 would be the best even if we decide that clients dont need it near term to decide how to select because it gives us the ability to keep track of it in segment and it really shouldn't be expensive

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

  1. Local setup

Screen Shot 2021-03-10 at 4 49 46 PM

...

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

@raymondjacobson raymondjacobson merged commit f2b02fe into master Mar 11, 2021
@raymondjacobson raymondjacobson deleted the rj-aud-375 branch March 11, 2021 17:58
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants