Multi wallet & collectibles #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Validate CN for associated_wallest in user metadata * Add associated wallets to Discovery DB * Add assocaited wallet to discovery schema * Update discovery indexing for user associated wallets * Add discovery endpoints for wallet - id * Add wallets schema to libs user validation
* Update associated_wallet schema and update disc. user balance on wallet update * Update schema in libs for associated wallets * Update validate metadata in creator for assciated wallet * Fix CN test * Add another check to CN metadata upload * Lint discovery * Update user schema validator in discovery and libs
* Support collectibles in libs * Support metadata multihash for collectibles in discovery * Add has_collectibles indexed field to user object * Fix wallet object check * Clean up
hareeshnagaraj
previously approved these changes
Mar 13, 2021
| user_record.name = metadata_overrides["name"] | ||
| if metadata_overrides["location"]: | ||
| user_record.location = metadata_overrides["location"] | ||
| if 'associated_wallets' in ipfs_metadata: |
There was a problem hiding this comment.
very minor question, should an empty dict be passed in if for some reason there previouslly was associated_wallets and now there are not? not 100 if that is even posssiible (idt so) with happy pathclient
There was a problem hiding this comment.
in the metadata object i mean
There was a problem hiding this comment.
the json schema should nullify it, so we should always have something here
raymondjacobson
approved these changes
Mar 13, 2021
hareeshnagaraj
pushed a commit
that referenced
this pull request
Mar 15, 2021
* Multi Wallet Support (#1296) * Validate CN for associated_wallest in user metadata * Add associated wallets to Discovery DB * Add assocaited wallet to discovery schema * Update discovery indexing for user associated wallets * Add discovery endpoints for wallet - id * Add wallets schema to libs user validation * Update schema and user balance for associated wallet (#1299) * Update associated_wallet schema and update disc. user balance on wallet update * Update schema in libs for associated wallets * Update validate metadata in creator for assciated wallet * Fix CN test * Add another check to CN metadata upload * Lint discovery * Update user schema validator in discovery and libs * Feature collectibles metadata multihash (#1292) * Support collectibles in libs * Support metadata multihash for collectibles in discovery * Add has_collectibles indexed field to user object * Fix wallet object check * Clean up * Do not check metadata from ipfs every time * Fix alembic collisions * Handle the null cases in user metadata indexing * Forgo image size changes * Fix clean metadata for new fields Co-authored-by: Joseph Lee <joeylee0925@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Saliou Diallo <saliou@audius.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Tested locally
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attentionlabel. Add relevant labels as necessary.Touches indexing