Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URSM Deployment Related Updates #1307

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Conversation

hareeshnagaraj
Copy link
Contributor

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Ensuring changes required after dry run on 3/15 are present on master. These include the following:

Migration update - mitigates the following failed seed node scenario:

Truffle-hd-wallet provider requirement in contracts/package.json - I had to install this in order to deploy the new set of contracts to stage

Registry check reordering - Check registry for new key at the top of each block instead of the top of each indexing task. Eliminates potential discrepancy from a discovery provider catching up during the deploy and missing the ursm seed nodes. For example, if a discovery provider processes the relevant blocks in a batch of 10 with the relevant seedNode tx block at index 3/10 - verifying ursm at the start of indexing would miss the blocks.

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

Verified on staging with details here - https://www.notion.so/audiusproject/3-15-21-URSM-Dry-Run-2-a4b7796f7e684e71949ebebe2bfe9efe

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one q but changes generally look good

contracts/truffle-config.js Show resolved Hide resolved
@hareeshnagaraj hareeshnagaraj merged commit c981803 into master Mar 16, 2021
@hareeshnagaraj hareeshnagaraj deleted the hn_ursm_deployment_updates branch March 16, 2021 17:57
@SidSethi
Copy link
Contributor

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants