Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
Ensuring changes required after dry run on 3/15 are present on master. These include the following:
Migration update - mitigates the following failed seed node scenario:
Contract created at block 19875069
URSM seedJob performed in block https://blockscout.com/poa/sokol/blocks/19875071/
URSM Contract added to registry in block 19875072 https://blockscout.com/poa/sokol/tx/0x668fd28b5e7f78930813a93d02d095a10802fe777444b24aa561fa9709476489/internal-transactions
Since the contract was added to the registry after the seedJob, the initial ursm_content_nodes are all missing
Fix:
Truffle-hd-wallet provider requirement in contracts/package.json - I had to install this in order to deploy the new set of contracts to stage
Registry check reordering - Check registry for new key at the top of each block instead of the top of each indexing task. Eliminates potential discrepancy from a discovery provider catching up during the deploy and missing the ursm seed nodes. For example, if a discovery provider processes the relevant blocks in a batch of 10 with the relevant seedNode tx block at index 3/10 - verifying ursm at the start of indexing would miss the blocks.
Tests
List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗
Verified on staging with details here - https://www.notion.so/audiusproject/3-15-21-URSM-Dry-Run-2-a4b7796f7e684e71949ebebe2bfe9efe
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attention
label. Add relevant labels as necessary.