Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUD-377] Add ip_check route #1316

Merged
merged 1 commit into from
Mar 17, 2021
Merged

[AUD-377] Add ip_check route #1316

merged 1 commit into from
Mar 17, 2021

Conversation

raymondjacobson
Copy link
Member

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Add IP check route to make sure that the proxy config for a discovery node is correct.

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

  1. Ran local service & set up ngrok and made sure that my IP was correctly reported

Screen Shot 2021-03-17 at 12 06 14 AM

...

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@cheran-senthil cheran-senthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 lgtm!

@raymondjacobson raymondjacobson merged commit 25f4045 into master Mar 17, 2021
@raymondjacobson raymondjacobson deleted the rj-aud-377 branch March 17, 2021 17:25
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants