Set end range in content stream if undefined #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We observed a sinister bug in Chrome when trying to stream a track from a content node behind a GCP load balancer. Other browsers and infrastructure worked fine, but Chrome would fail to stream.
The cause of this is that GCP LBs would send range
0-so the end is not set. When we set the headers, this headerres.set('Content-Length', end - start + 1)would be incorrect because end is an invalid value. I just set end to a valid value so all calculations should be correct.Tests
Hotfixed this tag on a stage node behind a GCP load balancer and the track streams.