Change middleware retry intervals #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
commented
Mar 18, 2021
|
|
||
| // Initial delay before polling | ||
| await utils.timeout(1000) | ||
| const MaxRetries = 201 |
There was a problem hiding this comment.
increased the duration by 1 sec because i got rid of the 1 sec initial timeout
|
Looks good to me, but I will leave ack to @SidSethi |
raymondjacobson
approved these changes
Mar 18, 2021
SidSethi
approved these changes
Mar 18, 2021
can't have CN get stuck infinitely retrying each user action right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lower the retry interval in content node middleware from 5s to 1s. This lag affects all write operations like upload/signup etc. Functionally, there's zero impact on middlewares.
Rationale for this change
Libs already polls on 500ms interval to confirm changes from discovery. Also 5s seems like it was picked so the validation can be in lock step with discovery indexing, but we've observed that indexing changes can be applied quite randomly. When compounded, these 5 second waits can add up.
Tests
Ran the system locally and did an upload