Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Batch CID route to creator node #1324

Merged
merged 26 commits into from
Mar 19, 2021
Merged

Add Batch CID route to creator node #1324

merged 26 commits into from
Mar 19, 2021

Conversation

cheran-senthil
Copy link
Contributor

Description

See #1310 for details

@cheran-senthil
Add script to get all user clock values
120d69c
@cheran-senthil
Batch requests to get CID propogation
563dad7
@cheran-senthil
Make changes to creator node to batch ipfs checks
1f6eaeb
@cheran-senthil
Make the script faster (?)
2fc265b
@cheran-senthil
Remove semicolons and format code
0bebaa1
@cheran-senthil
Check for file existence
da22be8
@cheran-senthil
Check for cover and profile photos
8693c92
@cheran-senthil
Check for existence
282c6dd
@cheran-senthil
Merge branch 'master' into vss-all-clock-val-script
effbf0f
@cheran-senthil
Merge branch 'master' into vss-all-clock-val-script
d80c1a3
@cheran-senthil
Handle errors better and reduce timeouts
690bf5b
@cheran-senthil
Have more readable json output
5732ef2
@cheran-senthil
Address PR comments:
d63b781 
* Get total number of users and tracks
* Change default discovery URL
* Rename variables for clarity
@cheran-senthil
Add Req Limiter
ce1385a
@cheran-senthil
Address most PR comments
a8eae35
@cheran-senthil
Fix config val error
d808836
@cheran-senthil
Fix CID script
66b5ace
@cheran-senthil
Move await out
afea595
@cheran-senthil
Delete script
64a4155
@cheran-senthil cheran-senthil added the content-node Content Node (previously known as Creator Node) label Mar 19, 2021
dmanjunath
dmanjunath previously requested changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good so far, some minor comments

creator-node/src/routes/files.js Outdated Show resolved Hide resolved
creator-node/src/routes/files.js Show resolved Hide resolved
creator-node/src/routes/files.js Outdated Show resolved Hide resolved
@cheran-senthil
Address PR comments:
364fcb8 
* check if cids exists
* Use let instead of const
* Use raw: true to make it more performant
SidSethi
SidSethi reviewed Mar 19, 2021
View reviewed changes
Copy link
Contributor

@SidSethi SidSethi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - couple nits then re-request

also don't forget to comment+close the old stale PRs, also would prefer you just copy/paste the PR description into this one rather than linking out

creator-node/docker-compose/development.env Outdated Show resolved Hide resolved
creator-node/default-config.json Outdated Show resolved Hide resolved
creator-node/src/routes/files.js Outdated Show resolved Hide resolved
creator-node/src/routes/files.js Outdated Show resolved Hide resolved
SidSethi
SidSethi previously approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@SidSethi SidSethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@SidSethi
Copy link
Contributor

also - make sure CI passes before merging (not a blocker for hotfixing to staging)

@cheran-senthil
Copy link
Contributor Author

Running mad-dog tests at https://app.circleci.com/pipelines/github/AudiusProject/audius-protocol/8543/workflows/f6f1859b-78d3-4f08-9eef-d22e55cf7aba/jobs/64590

@cheran-senthil cheran-senthil dismissed dmanjunath’s stale review March 19, 2021 19:42

Addressed changes requested

dmanjunath
dmanjunath approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@dmanjunath dmanjunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@cheran-senthil
Copy link
Contributor Author

mad-dog tests are still failing, https://app.circleci.com/pipelines/github/AudiusProject/audius-protocol/8550/workflows/741d368e-9c2c-41c8-ba2e-8a197cc87961/jobs/64649 but looks unrelated?

@cheran-senthil cheran-senthil merged commit c120330 into master Mar 19, 2021
@cheran-senthil cheran-senthil deleted the vss-hotfix-batch-cids branch March 19, 2021 20:50
@cheran-senthil
Copy link
Contributor Author

cheran-senthil commented Mar 20, 2021 •
edited

Forgot two brackets, this endpoint is borked, should be

({ storagePath }) => fs.pathExists(storagePath)

instead of,

( storagePath ) => fs.pathExists(storagePath)

Made changes on: #1310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanjunath dmanjunath dmanjunath approved these changes

@SidSethi SidSethi SidSethi approved these changes

Assignees

@hareeshnagaraj hareeshnagaraj

Labels
content-node Content Node (previously known as Creator Node)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheran-senthil @SidSethi @dmanjunath @hareeshnagaraj