Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URSM flag to libs init for optimizely #1333

Merged
merged 9 commits into from
Mar 22, 2021
Merged

Conversation

SidSethi
Copy link
Contributor

@SidSethi SidSethi commented Mar 22, 2021

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Add boolean flag to libs init enableUserReplicaSetManagerContract - allows for optimizely control of user URSM interaction

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

Confirmed behavior by flipping flag in libs/tests/helpers.js to true and false

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

libs/src/index.js Show resolved Hide resolved
libs/src/index.js Outdated Show resolved Hide resolved
libs/src/services/dataContracts/index.js Outdated Show resolved Hide resolved
@SidSethi SidSethi marked this pull request as ready for review March 22, 2021 18:48
@SidSethi SidSethi added the libs label Mar 22, 2021
@SidSethi
Copy link
Contributor Author

cc @raymondjacobson lets wire this up to client with optimizely config?

Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SidSethi SidSethi merged commit 3b8a84d into master Mar 22, 2021
@SidSethi SidSethi deleted the ss-ursm-optimizely branch March 22, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants