Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist Trending Fixes #1336

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Playlist Trending Fixes #1336

merged 3 commits into from
Mar 22, 2021

Conversation

piazzatron
Copy link
Contributor

Description

  • Add 'track_count' field required for UI for abbreviated playlists
  • Fix bug: playlists without reposts and saves would crash in the karma calculation
  • Fix bug: playlists without tracks would crash

Tests

Tested locally and on staging DP2

Copy link
Member

@raymondjacobson raymondjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Let's chat with @dmanjunath on seeing if we can get this bug fix into the release

discovery-provider/src/api/v1/helpers.py Show resolved Hide resolved
@piazzatron piazzatron merged commit 21bd565 into master Mar 22, 2021
@piazzatron piazzatron deleted the piazz-playlists-bug-logs branch March 22, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants