Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributed tracing #1342

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Add distributed tracing #1342

merged 4 commits into from
Mar 23, 2021

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Mar 23, 2021

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Add X-Request-ID header in libs to optionally log out if present on content node & identity service.
I opted to copy the same uuid() generation method we use in the dapp from SO. We currently include a few different versions of the uuid package in libs (inherited from crypto deps) and I don't want to add more bloat there.

Mad dog errors seem to be URSM related

TypeError: Cannot read property 'length' of undefined
    at LibsWrapper.getLibsUserInfo (/home/circleci/project/service-commands/src/libs.js:388:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)
2021-03-23T18:19:44.594Z error: 	Failed test [userReplicaSetManager] with error [Issue with creating and upgrading users: TypeError: Cannot read property 'length' of undefined]
2021-03-23T18:19:44.594Z error: 	Exiting testrunner with errors
2021-03-23T18:19:44.594Z error: 	

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

  1. Ran stack locally & tested requests from client with a generated X-Request-ID and ensured the service logged that out
  2. Ran stack locally & tested that without the client providing X-Request-ID, the old short-form request id is logged
    ...

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

@raymondjacobson raymondjacobson merged commit 8e5b53b into master Mar 23, 2021
@raymondjacobson raymondjacobson deleted the rj-distrib-tracing branch March 23, 2021 20:59
dmanjunath pushed a commit that referenced this pull request Mar 24, 2021
* Add X-Request-ID libs header

* Use X-Request-ID in identity

* Use X-Request-ID in content node

* Add additional log
@SidSethi
Copy link
Contributor

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants