De-dupe sync tasks #1346
Merged
De-dupe sync tasks #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidSethi
commented
Mar 24, 2021
| @@ -141,15 +141,32 @@ async function ensureStorageMiddleware (req, res, next) { | |||
| * @dev - TODO move this out of middlewares to Services layer | |||
| */ | |||
| async function triggerSecondarySyncs (req) { | |||
| if (config.get('isUserMetadataNode') || config.get('snapbackDevModeEnabled')) return | |||
| const { snapbackSM } = serviceRegistry | |||
There was a problem hiding this comment.
every change in this file is just code cleanup, except for line 165 (the enqueueSync() call
SidSethi
commented
Mar 24, 2021
| primaryEndpoint, | ||
| secondaryEndpoint, | ||
| userWallet, | ||
| primaryClockValue, |
There was a problem hiding this comment.
removing primaryClockValue from job inputs since it is unrelated and it also makes it impossible to dedupe syncs effectively
SidSethi
added
bug
vicky-g
reviewed
Mar 25, 2021
|
Merging despite mad-dog failure as it is the same 404 error and already tested on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
Spec in Notion
Problem: often see multiple syncs in queue for same user/secondary - this is redundant and takes spots away from other syncs
Solution: Bull provides no helpful API, so implemented an in-memory map to record progress syncs and prevent duplicate syncs from being enqueued.
Tests
List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗
Snapback integration & system tests passing
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attentionlabel. Add relevant labels as necessary.