Add a batched image CID route to creator node #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheran-senthil
added
the
content-node
cheran-senthil
force-pushed
the
vss-batch-image-cid
branch
from
ce10e2f
to
fd00b10
Compare
SidSethi
approved these changes
Mar 26, 2021
| return errorResponseBadRequest(`Too many CIDs passed in, limit is ${BATCH_CID_ROUTE_LIMIT}`) | ||
| } | ||
|
|
||
| const queryResults = (await models.File.findAll({ |
There was a problem hiding this comment.
did we decide to not add a type != image for the non-image batch CID route?
There was a problem hiding this comment.
Yes, because we still want to support the existence of directory check.
There was a problem hiding this comment.
right - sounds good, can you add comment to that effect 🙂
There was a problem hiding this comment.
* @param {string[]} req.body.cids the cids to check existence for, these cids can also be directories
This comment should explain that already, if you think that is sufficient, I think this is good to merge now too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continues from: #1310
Adds a batched image CID route to creator node, so that #1310 works.
Tests
Stage testing as well as load testing for the new route is pending.