Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move trending to the 15 minute mark to space out crons #1362

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

raymondjacobson
Copy link
Member

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

Refreshing trending is expensive and so is sweeping / calculating metrics. No need to do these both at the hour on the dot.

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

🤷‍♂️
...

❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the requires-special-attention label. Add relevant labels as necessary.

Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! is this to space out expensive db operations from the 0th minute? wondering if there's other stuff in a similar predicament

@raymondjacobson
Copy link
Member Author

looks good to me! is this to space out expensive db operations from the 0th minute? wondering if there's other stuff in a similar predicament

Yeah exactly. There are two metrics jobs at the 0th minute, but those have time "sensitivity" since they care about metrics by the hour. Could move them too but a bit more complicated. This one was just easy.

Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea

@raymondjacobson raymondjacobson merged commit e127f22 into master Mar 31, 2021
@raymondjacobson raymondjacobson deleted the rj-spread-jobs branch March 31, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants