Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
Spent forever playing with aac encoders, etc. etc. etc. and turns out this is the issue.
Tracks > 1:30 will fail at 10:06 (the 101st segment) because of this line
https://github.com/AudiusProject/audius-protocol/blob/master/creator-node/src/ffmpeg.js#L42
which reads segments from the dir in alphabetical order -- those files will be
000.ts
001.ts
...
100.ts
1000.ts
1001.ts
...
1009.ts
101.ts
...
This as you imagine can break * a lot * of things
We have a few ways we can handle this client side for old tracks, but let's get this in ASAP.
Either way we should be able to patch this over as soon as we can take this out to prod
Tests
List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗
...
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attention
label. Add relevant labels as necessary.