Return -1 if clock value not found for batch requests, not undefined

[vicky-g]

Description

What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?

If you fetch a wallet with no state on the current cnode to this request, there will not be a response. This fix is to return -1 for those users.

Tests

List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗

Test request:

  const axiosReqParams = {
    baseURL: 'http://cn1_creator-node_1:4004',
    url: '/users/batch_clock_status',
    method: 'post',
    data: {
      walletPublicKeys: [
        // this wallet has data on CN
        '0x4749a62b82983fdcf19ce328ef2a7f7ec8915fe5',

        // these two wallets do not have data on CN
        '0xe5669383629208e8b30dbe9e04e13c325f5cb809',
        '0x13d350973206d8fc2420a11ea4bb9edaa94ef2e1'
      ]
    }
  }

  const userClockValuesResp = (await axios(axiosReqParams)).data.data.users

  console.log(userClockValuesResp)

Current example logs:

[ { walletPublicKey: '0x13d350973206d8fc2420a11ea4bb9edaa94ef2e1',
    clock: 62 } ]

PR fix response from axios:

[ { walletPublicKey: '0x13d350973206d8fc2420a11ea4bb9edaa94ef2e1',
    clock: 62 },
  { walletPublicKey: '0x4749a62b82983fdcf19ce328ef2a7f7ec8915fe5',
    clock: -1 },
  { walletPublicKey: '0xe5669383629208e8b30dbe9e04e13c325f5cb809',
    clock: -1 } ]

How will this change be monitored?

No monitoring necessary

[hareeshnagaraj]

LGTM, great find!

[SidSethi]

goood find