Speed up remixables query by a lot #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
force-pushed
the
rj-speed-up-remixables
branch
from
c8ffc26
to
e2d27bd
Compare
Kyle-Shanks
previously approved these changes
Jul 15, 2021
raymondjacobson
force-pushed
the
rj-speed-up-remixables
branch
from
e2d27bd
to
c228afb
Compare
Kyle-Shanks
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
Use aggregate_track for counting scores for remixables. This is far more performant. Query takes < 0.5s. There's an offline job here: https://github.com/AudiusProject/audius-protocol/blob/cefbc039c533797ae78584cd5f8c3dc1bbc3841b/discovery-provider/src/tasks/index_aggregate_views.py
that computes summed repost + save counts for all tracks.
The rest of explore should be refactored to use this, but since the playlists/albums and saves/reposts for playlists/albums is generally much smaller, it doesn't have as gnarly as a performance situation.
Sorry the diff here is a bit large -- autoformatting FTW though. The only change is the
count_subqueryTests
List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗
...
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attentionlabel. Add relevant labels as necessary.How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.