Increase rateLimitingUserReqLimit to 60000 reqs / hr / IP to prevent Snapback causing nodes to rate limit each other
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
suggested changes
Jul 19, 2021
SidSethi
changed the title
GET /users/clock_status/* route rate limits to 1000 reqs/minrateLimitingUserReqLimit to 60000 reqs / hr / IP
SidSethi
changed the title
rateLimitingUserReqLimit to 60000 reqs / hr / IPrateLimitingUserReqLimit to 60000 reqs / hr / IP to prevent Snapback causing nodes to rate limit each other
dmanjunath
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
New Snapback programmatic consumption of
/users/clock_status/*route leads to hitting the global/users/*routes rate limit very quickly, causing snapback to short-circuit incorrectly and make our logs useless.Prod and staging do not override this config anywhere, so they will automatically use the value I've defined here in
default-config.jsonTests
Tested locally, confirmed rate limit is correctly applied to
/users/clock_status/*route❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attentionlabel. Add relevant labels as necessary.How will this change be monitored?
We should not see a significant number of 429s in CN Snapback logs