Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect Verified Challenge #1702

Merged
merged 6 commits into from
Aug 6, 2021
Merged

Connect Verified Challenge #1702

merged 6 commits into from
Aug 6, 2021

Conversation

jowlee
Copy link
Contributor

@jowlee jowlee commented Jul 29, 2021

Description

User Challenge for connecting oauth and being verified

Changes

  • Add an entry in challenges.json file -> creates a new entry in the DB for challenges for connect-verified
  • Creates a new ChallengeUpdater for the connect verified challenge
  • Adds a migration for all the old users that were verified to have a completed user_challenge

Closes AUD-710

Tests

Wrote a test for the challenge manager
Locally set up the system and verified a user, then checked that the user_challenge was created and marked as completed.
Ran the migration against the staging DB and verified that for all verified users, a completed connect_verified user_challenge was created

How will this change be monitored?

@jowlee jowlee added feature New features discovery-node Discovery Node (previously known as Discovery Provider) labels Jul 29, 2021
@jowlee jowlee requested a review from piazzatron July 29, 2021 18:33
@jowlee jowlee changed the title Jowlee verified challenge Connect Verified Challenge Jul 29, 2021
@Kyle-Shanks
Copy link
Contributor

LGTM pending the event_args._isVerified thing and the challenge amount. I like how clean and simple this challenge is 👌

@jowlee jowlee requested a review from Kyle-Shanks August 3, 2021 17:08
@jowlee jowlee merged commit 30e33ef into master Aug 6, 2021
@jowlee jowlee deleted the jowlee-verified-challenge branch August 6, 2021 15:35
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kyle-Shanks Kyle-Shanks Kyle-Shanks approved these changes

@piazzatron piazzatron Awaiting requested review from piazzatron

Assignees

@Kyle-Shanks Kyle-Shanks

Labels
discovery-node Discovery Node (previously known as Discovery Provider) feature New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jowlee @Kyle-Shanks