Update track upload challenge #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sddioulde
force-pushed
the
sd-test-challenges
branch
5 times, most recently
from
0ad120d
to
934c28c
Compare
sddioulde
force-pushed
the
sd-test-challenges
branch
from
934c28c
to
6b282bb
Compare
Kyle-Shanks
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
Update track upload challenge. Increase block number to a number far in the future. Update completion condition for the challenge. Update code to behave nicely with linting.
Tests
List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗
Deployed changes to prod sandbox, ran ui against prod and chose sandbox DP, uploaded tracks and made sure db showed correct records when challenge was not completed and also when it was completed.
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attentionlabel. Add relevant labels as necessary.How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.