[AUD-726] Support create sender public in discovery #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
added
the
discovery-node
raymondjacobson
force-pushed
the
rj-create-signer-discovery
branch
from
d34860a
to
b9d7760
Compare
raymondjacobson
force-pushed
the
rj-create-signer-discovery
branch
from
b9d7760
to
bf5165c
Compare
raymondjacobson
force-pushed
the
rj-create-signer-discovery
branch
from
bf5165c
to
5498e32
Compare
piazzatron
approved these changes
Nov 19, 2021
rickyrombo
added a commit
that referenced
this pull request
Nov 20, 2021
This reverts commit 6492534.
rickyrombo
added a commit
that referenced
this pull request
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for "attesting" to new senders (signers in the rewards manager). Combined with libs changes in #1790 can interact w/ reward mgr to program to add new senders.
Note: the first version of this PR was landed in #2026 as a means to support restructuring of get_other_nodes to support this pattern w/o circular deps & allow for Cheran's changes.
Those two relevant commits are:
7fe5cff
b9d7760
Tests
How will this change be monitored?
Initially no impact on discovery node other than a new endpoint