-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UserBalanceChange table and add code to handle tier change notifications #1930
Merged
Kyle-Shanks
merged 2 commits into
master
from
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
Nov 22, 2021
Merged
Add UserBalanceChange table and add code to handle tier change notifications #1930
Kyle-Shanks
merged 2 commits into
master
from
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowlee
reviewed
Oct 1, 2021
sddioulde
reviewed
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending the balance sum comment
Kyle-Shanks
force-pushed
the
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
branch
from
October 25, 2021 17:41
18df1f5
to
0341b28
Compare
Kyle-Shanks
force-pushed
the
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
branch
4 times, most recently
from
October 25, 2021 19:56
a38e02b
to
915141a
Compare
sddioulde
reviewed
Nov 1, 2021
identity-service/src/notifications/sendNotifications/formatNotification.js
Outdated
Show resolved
Hide resolved
Kyle-Shanks
force-pushed
the
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
branch
from
November 4, 2021 15:09
915141a
to
35e50ea
Compare
jowlee
approved these changes
Nov 9, 2021
sddioulde
approved these changes
Nov 22, 2021
) | ||
) | ||
|
||
# user_balance.balance = owner_wallet_balance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment
Kyle-Shanks
force-pushed
the
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
branch
from
November 22, 2021 19:53
35e50ea
to
e82a0a7
Compare
Kyle-Shanks
force-pushed
the
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
branch
from
November 22, 2021 20:04
e82a0a7
to
3ac4bd7
Compare
Kyle-Shanks
deleted the
kj-Add-UserBalanceChange-table-and-tier-change-notification-indexing
branch
November 22, 2021 20:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Tests can be added to verify that indexing works properly