[ASI-593] Check all gateways if content cant be found in user replica set and IPFS #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dm-try-all-gateways-saveFileForMultihashToFS
SidSethi
reviewed
Nov 5, 2021
….com:AudiusProject/audius-protocol into dm-try-all-gateways-saveFileForMultihashToFS
|
@SidSethi updated to de-dupe |
SidSethi
reviewed
Nov 5, 2021
creator-node/src/utils.js
Outdated
| const attemptedStateFix = await getIfAttemptedStateFix(filePath) | ||
| if (attemptedStateFix) return | ||
|
|
||
| // get list of creator nodes | ||
| const creatorNodes = await getAllRegisteredCNodes(libs) | ||
| if (!creatorNodes.length) return | ||
|
|
||
| // Remove excluded nodes from list of creator nodes, no-op if empty list or nothing passed in | ||
| const creatorNodesFiltered = creatorNodes.filter(c => excludeList.includes(c.endpoint)) |
There was a problem hiding this comment.
shouldn't this be !excludeList.includes
There was a problem hiding this comment.
ah yes you are correct! sorry its been a long day lol
There was a problem hiding this comment.
hahaha all good dude - would be good to make sure new code path still works
also i re-ran maddog ci since it failed for non-relevant reason
SidSethi
approved these changes
Nov 5, 2021
SidSethi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because we added skips in the sync logic recently, it's possible content is still on another node but our node is unable to retrieve it since it doesn't try all other gateways. This leverages an existing code path that searches (with a cache to avoid retrying more than once a day).
Tests
Tested locally to make sure code flow works. Underlying function used has been in production for over a year.
How will this change be monitored?
Loggly logs