[AUD-1084] Don't filter deleted so that we can get tombstones on the client #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyrombo
added
the
discovery-node
raymondjacobson
approved these changes
Nov 10, 2021
| tracks = get_tracks( | ||
| {"routes": routes_parsed, "with_users": True, "filter_deleted": True} | ||
| ) | ||
| tracks = get_tracks({"routes": routes_parsed, "with_users": True}) |
There was a problem hiding this comment.
let's triple check the places we call this API, but this change seems right
There was a problem hiding this comment.
- RemixSettingsModal: https://github.com/AudiusProject/audius-client/blob/aa685d2174dd5d9457dfb79ac18a5553ba118d5d/src/containers/remix-settings-modal/store/sagas.ts#L40
- Probably should filter this, don't think we want users remixing deleted tracks?
- RemixesPage: https://github.com/AudiusProject/audius-client/blob/f168424acf90273f59b0e8e51237c82dd8dac057/src/containers/remixes-page/store/sagas.ts#L17
- TrackPage: https://github.com/AudiusProject/audius-client/blob/f168424acf90273f59b0e8e51237c82dd8dac057/src/containers/track-page/store/sagas.js#L114
There was a problem hiding this comment.
@raymondjacobson ping :)
jowlee
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tombstones weren't working in the client because the track endpoint for routes is filtering deleted tracks.
Tests
Tested manually against local client
How will this change be monitored?