Reduce aggregate user full refresh frequency #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
approved these changes
Nov 11, 2021
csjiang
reviewed
Nov 11, 2021
| @@ -10,7 +10,10 @@ | |||
| # Names of the aggregate tables to update | |||
| AGGREGATE_USER = "aggregate_user" | |||
| DEFAULT_UPDATE_TIMEOUT = 60 * 30 # 30 minutes | |||
| REFRESH_COUNTER = 100 | |||
|
|
|||
| # every ~10000 updates, refresh the entire table | |||
There was a problem hiding this comment.
is this every 10000 updates or every 1000 updates? REFRESH_COUNTER seems to be 1000. Also where is the 30s interval? (Just trying to get context.)
There was a problem hiding this comment.
oops fixed my comment typo. the interval is here
audius-protocol/discovery-provider/src/app.py
Line 445 in 6c30c56
dmanjunath
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Reduce aggregate user full refreshes * fix comment typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The full refreshes that happen once every ~100 updates for aggregate_user seems to block other queries. For now, we can reduce the frequency to prevent this. Next we'll separate the truncate from the update transaction and do a drop/replace.
Tests
How will this change be monitored?