Update aggregate user repopulate to use the past two weeks #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsolo
commented
Nov 15, 2021
| most_recent_indexed_aggregate_block = 0 | ||
| session.execute("TRUNCATE TABLE {}".format(table_name)) | ||
| elif latest_indexed_block_num % REFRESH_COUNTER == 0: |
There was a problem hiding this comment.
I'm not liking this random behavior anymore. Gonna change this to use a last completed timestamp saved in redis, then update based on that.
isaacsolo
changed the title
dmanjunath
suggested changes
Nov 19, 2021
| most_recent_indexed_aggregate_block = 0 | ||
| session.execute("TRUNCATE TABLE {}".format(table_name)) | ||
| redis.set( |
There was a problem hiding this comment.
we should move these redis.set calls after the session.execute. otherwise i think this could cause some inconsistency? like to avoid the case where a condition like variable gets set in redis but the worker gets restarted before completing so the db isn't actually updated. we should move it near the other redis.set after the execute
dmanjunath
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running a full refresh with a truncate blocks other queries on aggregate_user. Since there are several dependencies on aggregate_user, we cannot simply do a drop and replace on that. We'd have to drop and recreate those dependencies too.
This change reduces the frequency of refreshes to about once a day and only refreshes user data from the past two weeks, reducing the frequency and duration of potential blocking.
Tests
Run locally against prod snapshot.
Verified updates in different states: refresh past two weeks, full recreation when cache is empty, regular updates.
How will this change be monitored?