Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_deactivated to playlist.user response of get_account #2076

Merged
merged 4 commits into from
Nov 20, 2021

Conversation

rickyrombo
Copy link
Contributor

@rickyrombo rickyrombo commented Nov 18, 2021

Description

Updates get_account query to add is_deactivated when true to attached user metadata, to prevent flashing deactivated account playlists in the UI on the client while we wait to load users for the full playlists.

Tests

  • Tested the account endpoint with dummy data manually inserted into remote dev DB
  • Will test E2E with client changes Deactivate Account audius-client#657 post merge/deploy to staging for richer dataset

How will this change be monitored?

N/A

QUESTIONS

  • Why do both playlist_library and playlists exist?
    • Answered offline (because library can have folders, order, etc, and doesn't include metadata)
  • Why do we not include more data on the users here (or not at all) since we seem to pull user info on the client later anyway?
    • Answered offline (because of performance reasons)

@rickyrombo rickyrombo added the discovery-node Discovery Node (previously known as Discovery Provider) label Nov 18, 2021
@rickyrombo rickyrombo changed the title Remove playlists from account that have deactivated owners Add is_deactivated to playlist.user so that accounts don't flicker deactivated playlists on load Nov 18, 2021
@rickyrombo rickyrombo changed the title Add is_deactivated to playlist.user so that accounts don't flicker deactivated playlists on load Add is_deactivated to playlist.user response of get_account Nov 18, 2021
@rickyrombo rickyrombo merged commit ff46b65 into master Nov 20, 2021
@rickyrombo rickyrombo deleted the mjp-hide-deactivated-playlists branch November 20, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery-node Discovery Node (previously known as Discovery Provider)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants